strong signed build tools assemblies. Creating a new target for devop…#5076
strong signed build tools assemblies. Creating a new target for devop…#5076shahabhijeet merged 3 commits intoAzure:LTSBuildToolsfrom
Conversation
…s sceanario where packaging of nuget pacakges need to be generated without rebuilding.
| <AssemblyOriginatorKeyFile>$(LibraryToolsFolder)\MSSharedLibKey.snk</AssemblyOriginatorKeyFile> | ||
| <NoWarn>1591;1701;1573;CS1591</NoWarn> | ||
| <DefaultPathTokenToIgnore>$(DefaultPathTokenToIgnore) $(IgnorePathTokens)</DefaultPathTokenToIgnore> | ||
| <DefaultPathTokenToIgnore>$(DefaultPathTokenToIgnore) $(IgnorePathTokens) Microsoft.Azure.KeyVault.Samples</DefaultPathTokenToIgnore> |
There was a problem hiding this comment.
Did you intentionally add KeyVault.Samples back to the list?
There was a problem hiding this comment.
This was a mistake, my merge was not done right. Thanks for catching this.
Will fix it.
| This target is primarily being used by DevOps pipeline scenario for data plan which is using VSO tasks to sign. | ||
| So this target assumes build outputs are already generated and would simply like to package the | ||
| signed artificats (without rebuilding) | ||
| NOTE: This package cannot be used independently, will get an error as build outputs are not generated. |
There was a problem hiding this comment.
I assume you meant "This package" -> "This target".
There was a problem hiding this comment.
@weshaggard @kurtzeborn I have made one minor change and added a new target so that it can be used without affecting existing linked targets.
This new target can be used exactly what you intended for, except the new name.
There was a problem hiding this comment.
My comment was talking about the typo where I think you wanted to say "target" and not "package".
...ldTasks/Microsoft.Azure.Sdk.Build.Tasks/SdkBuildTasks/Microsoft.Azure.Sdk.Build.Tasks.csproj
Outdated
Show resolved
Hide resolved
| <TaskBinaryOutput>..\..\..\tasks</TaskBinaryOutput> | ||
| </PropertyGroup> | ||
| <PropertyGroup> | ||
| <TargetFramework>net46</TargetFramework> |
There was a problem hiding this comment.
Where is TargetFramework getting set to net46 now?
There was a problem hiding this comment.
I don't quite follow the "where" part.
If you are wondering why are we targeting .NET 46, then all our build tools are targeting net 46 and above.
There was a problem hiding this comment.
The where question is because you removed this property from this project so I was curious where it is getting set now.
2 participants
This is a new PR with all the feedback addressed from #5071