Skip to content

Allow repo's to set DefaultPathTokenToIgnore property #5075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shahabhijeet merged 1 commit into from
Dec 11, 2018
Merged

Allow repo's to set DefaultPathTokenToIgnore property #5075

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tools/BuildAssets/targets/common.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<DelaySign>true</DelaySign>
<AssemblyOriginatorKeyFile>$(LibraryToolsFolder)\MSSharedLibKey.snk</AssemblyOriginatorKeyFile>
<NoWarn>1591;1701;1573;CS1591</NoWarn>
<DefaultPathTokenToIgnore>$(IgnorePathTokens) Microsoft.Azure.KeyVault.Samples</DefaultPathTokenToIgnore>
<DefaultPathTokenToIgnore>$(DefaultPathTokenToIgnore) $(IgnorePathTokens)</DefaultPathTokenToIgnore>
Copy link
Member Author

@weshaggard weshaggard Dec 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shahabhijeet I removed Microsoft.Azure.KeyVault.Samples from this list because I believe you told me it is no longer needed if that isn't the case or I misunderstood I can keep it here.

<BuildWideDebugTrace Condition=" '$(DebugTrace)' == '' ">false</BuildWideDebugTrace>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
</PropertyGroup>
Expand All @@ -28,7 +28,7 @@
<PropertyGroup>
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
</PropertyGroup>

<PropertyGroup Condition=" '$(Configuration)' == 'Release' ">
<SignAssembly>true</SignAssembly>
<DelaySign>true</DelaySign>
Expand All @@ -46,8 +46,8 @@
<UnsignedPackageRootDir>$(PackageRootDir)\unsigned</UnsignedPackageRootDir>
<SignedPackageRootDir>$(PackageRootDir)\signed</SignedPackageRootDir>
</PropertyGroup>
<PropertyGroup>

<PropertyGroup>
<BuildNameLabel>DesktopBuild</BuildNameLabel>
</PropertyGroup>

Expand Down