Skip to content

[Storage] Support Failover, and blob Service#5016

Merged
dsgouda merged 5 commits intoAzure:psSdkJson6from
blueww:failover2
Nov 16, 2018
Merged

[Storage] Support Failover, and blob Service#5016
dsgouda merged 5 commits intoAzure:psSdkJson6from
blueww:failover2

Conversation

@blueww
Copy link
Member

@blueww blueww commented Nov 14, 2018

Description

Swagger PR:

The SDK is currently generated from a temp repo with contains all the above swagger PR change.
Will regenerate it against public swagger when all the swagger PR merged.


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part, please regenerate the code when spec is merged

return new Tuple<string, string, string>[]
{
new Tuple<string, string, string>("Storage", "BlobContainers", "2018-07-01"),
new Tuple<string, string, string>("Storage", "BlobServices", "2018-07-01"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please pull down latest changes from remote and run msbuild build.proj and regenerate the code.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsgouda
I have updated the PR per the public swagger, and run msbuild build.proj (Anyway, don't see any change by run msbuild).
Would you please help to review and merge the PR asap?
Thanks!

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

<Description>Microsoft Azure Management Storage Library</Description>
<AssemblyName>Microsoft.Azure.Management.Storage</AssemblyName>
<Version>9.0.0-preview</Version>
<Version>9.1.0-preview</Version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blueww When are you planning to release a stable version? Ideally you should have started preview versioning from 8.8.0-preview and landed on 9.0.0 stable version. Do let us know when you are planning to move to version 10 so we can provide a better idea.
Not blocking on this

@dsgouda dsgouda merged commit b761f02 into Azure:psSdkJson6 Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants