[Storage] Support Failover, and blob Service#5016
Conversation
dsgouda
left a comment
There was a problem hiding this comment.
Looks good for the most part, please regenerate the code when spec is merged
| return new Tuple<string, string, string>[] | ||
| { | ||
| new Tuple<string, string, string>("Storage", "BlobContainers", "2018-07-01"), | ||
| new Tuple<string, string, string>("Storage", "BlobServices", "2018-07-01"), |
There was a problem hiding this comment.
Please pull down latest changes from remote and run msbuild build.proj and regenerate the code.
There was a problem hiding this comment.
@dsgouda
I have updated the PR per the public swagger, and run msbuild build.proj (Anyway, don't see any change by run msbuild).
Would you please help to review and merge the PR asap?
Thanks!
| <Description>Microsoft Azure Management Storage Library</Description> | ||
| <AssemblyName>Microsoft.Azure.Management.Storage</AssemblyName> | ||
| <Version>9.0.0-preview</Version> | ||
| <Version>9.1.0-preview</Version> |
There was a problem hiding this comment.
@blueww When are you planning to release a stable version? Ideally you should have started preview versioning from 8.8.0-preview and landed on 9.0.0 stable version. Do let us know when you are planning to move to version 10 so we can provide a better idea.
Not blocking on this
Description
Swagger PR:
The SDK is currently generated from a temp repo with contains all the above swagger PR change.
Will regenerate it against public swagger when all the swagger PR merged.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.