Skip to content

Conversation

@jviau
Copy link
Contributor

@jviau jviau commented Oct 31, 2018

Description

Update DevTestLab to 2018-09-15. Azure/azure-rest-api-specs#4357

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.
    • Have new tests locally, will add in a different PR. This SDK version is already used internally by us, so it has been tested by that.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the failing tests

@jviau jviau force-pushed the devtestlab/2018-09-15 branch from 9996e58 to 1438bbe Compare November 1, 2018 20:50
@jviau
Copy link
Contributor Author

jviau commented Nov 1, 2018

@dsgouda I have fixed the test and updated release notes.

@jviau
Copy link
Contributor Author

jviau commented Nov 5, 2018

ping @dsgouda. Any other changes I need to make?

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 98c9dc2 into Azure:psSdkJson6 Nov 5, 2018
@jviau
Copy link
Contributor Author

jviau commented Nov 6, 2018

Thank you @dsgouda. Do you know when the nuget package will be published? Or is there more steps before it is published.

@jviau jviau deleted the devtestlab/2018-09-15 branch November 6, 2018 17:35
@dsgouda
Copy link
Contributor

dsgouda commented Nov 6, 2018

@jviau Steps to publish could be found here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants