Skip to content

[HDInsight] Fixed applications and MSI, added application test#4989

Merged
dsgouda merged 1 commit intoAzure:psSdkJson6from
wawon-msft:hdiapps
Nov 1, 2018
Merged

[HDInsight] Fixed applications and MSI, added application test#4989
dsgouda merged 1 commit intoAzure:psSdkJson6from
wawon-msft:hdiapps

Conversation

@wawon-msft
Copy link
Contributor

Description

Regenerating from Swaggers with changes in this PR: Azure/azure-rest-api-specs#4364

This change is technically a breaking change, as we are removing a parameter. However, there should be no users affected, as this method would always have thrown an error from the SDK. Additionally, a new test has been added to verify that this call works properly.

There is a minor fix to customization related to MSI, where a property in a custom data model was private when it should have been public.


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda
Copy link
Contributor

dsgouda commented Oct 31, 2018

Will merge on CIs passing

@dsgouda dsgouda merged commit 7bdf081 into Azure:psSdkJson6 Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants