Skip to content

Dabarger/local search api#4962

Merged
shahabhijeet merged 6 commits intoAzure:psSdkJson6from
davidbargeron:dabarger/local_search_api
Oct 31, 2018
Merged

Dabarger/local search api#4962
shahabhijeet merged 6 commits intoAzure:psSdkJson6from
davidbargeron:dabarger/local_search_api

Conversation

@davidbargeron
Copy link
Copy Markdown
Contributor

@davidbargeron davidbargeron commented Oct 29, 2018 •
edited
Loading

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • [NA] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.ps1 file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

shahabhijeet
shahabhijeet suggested changes Oct 30, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@shahabhijeet shahabhijeet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add link to your swagger RP in description.
Once the swagger RP is merged, the SDK needs to be regenerated again to pick up the latest/merged swagger.

Any reason tests are not part of this SDK?
If you cannot add tests, please create an issue and describe the plan to add tests and assign the issue to your team.
Also as this is your first version, we advice you go as -preview, in this case go as 0.9.0-preview. We have quite often seen RPs going as stable as their first version end up introducing breaking changes due to things getting missed or pure customer feedback and end up releasing multiple major version upgraded within a period of month.
one such example
https://www.nuget.org/packages/Microsoft.Azure.Management.StorageSync/
The above RP has now understood and have decide to use -preview as their next release.

shahabhijeet
shahabhijeet suggested changes Oct 31, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the existing comments.
Still missing release notes and one minor edit

@shahabhijeet shahabhijeet merged commit a50c4ab into Azure:psSdkJson6 Oct 31, 2018
@davidbargeron davidbargeron deleted the dabarger/local_search_api branch October 31, 2018 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yangyuan yangyuan yangyuan left review comments

+1 more reviewer

@shahabhijeet shahabhijeet shahabhijeet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@davidbargeron @yangyuan @shahabhijeet @dsgouda