Skip to content

Newtonsoft#4931

Merged
shahabhijeet merged 3 commits intoAzure:psSdkJson6from
maddieclayton:newtonsoft
Oct 26, 2018
Merged

Newtonsoft#4931
shahabhijeet merged 3 commits intoAzure:psSdkJson6from
maddieclayton:newtonsoft

Conversation

@maddieclayton
Copy link
Copy Markdown
Contributor

@maddieclayton maddieclayton commented Oct 26, 2018

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

brjohnstmsft
brjohnstmsft approved these changes Oct 26, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@brjohnstmsft brjohnstmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Search changes look good to me

@shahabhijeet shahabhijeet merged commit 59c76f2 into Azure:psSdkJson6 Oct 26, 2018
v-djnisi pushed a commit to v-djnisi/azure-sdk-for-net that referenced this pull request Oct 30, 2018
@v-djnisi
Newtonsoft (Azure#4931)
34e67f4 
* update version of newtonsoft json

* Update AzSdk.test.reference.props

* Update Sql.Tests.csproj
ahamad-MS pushed a commit to ahamad-MS/azure-sdk-for-net that referenced this pull request Oct 31, 2018
Newtonsoft (Azure#4931)
3e83756 
* update version of newtonsoft json

* Update AzSdk.test.reference.props

* Update Sql.Tests.csproj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@brjohnstmsft brjohnstmsft brjohnstmsft approved these changes

@shahabhijeet shahabhijeet shahabhijeet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maddieclayton @brjohnstmsft @shahabhijeet