added 2.1 preview SDK for text analytics#4872
Merged
Merged
Conversation
Contributor
Author
Contributor
|
We do not allow multiple versions of SDK in the repo. We need to understand your requirements offline here |
Contributor
Author
|
@dsgouda based on the discussion I have made it to one sdk instead of two. |
dsgouda
suggested changes
Oct 23, 2018
Contributor
dsgouda
left a comment
dsgouda
left a comment
There was a problem hiding this comment.
Please link the related REST spec PR
| cmd.exe /c autorest.cmd https://github.com/Azure/azure-rest-api-specs/blob/master/specification/cognitiveservices/data-plane/TextAnalytics/readme.md --csharp --version=latest --reflect-api-versions --csharp.output-folder=E:\azure-sdk-for-net\src\SDKs\CognitiveServices\dataPlane\Language\TextAnalytics\TextAnalytics\Generated\TextAnalytics | ||
| 2018-07-26 19:20:31 UTC | ||
| 1) azure-rest-api-specs repository information | ||
| cmd.exe /c autorest.cmd https://github.com/Azure/azure-rest-api-specs/blob/master/specification/cognitiveservices/data-plane/TextAnalytics/readme.md --csharp --version=latest --reflect-api-versions --tag=release_2_1 --csharp.output-folder=C:\azure-sdk-for-net\src\SDKs\CognitiveServices\dataPlane\Language\TextAnalytics\TextAnalytics-2.1-preview\Generated\TextAnalytics-2.1-preview |
Contributor
There was a problem hiding this comment.
This log looks incorrect. please regenerate the code. The csharp.output-folder should not be TextAnalytics-2.1-preview
Contributor
Author
|
@dsgouda Added the rest api PR and also updated the log files by regenerating the code |
Contributor
|
@laramume please update the |
v-djnisi
pushed a commit
to v-djnisi/azure-sdk-for-net
that referenced
this pull request
Oct 30, 2018
* added 2.1 preview SDK for text analytics * added 2.1 preview SDK for text analytics * separated two versions into two different projects * changed generate powershell script for the preview sdk * added 2.1 preview SDK for text analytics * based on PR commanets changed the number of SDK's to one * fixed test project errors * fixed test project errors * fixed test project errors * fixed test project errors * fixed the log errors * changed the version name and package notes
ahamad-MS
pushed a commit
to ahamad-MS/azure-sdk-for-net
that referenced
this pull request
Oct 31, 2018
* added 2.1 preview SDK for text analytics * added 2.1 preview SDK for text analytics * separated two versions into two different projects * changed generate powershell script for the preview sdk * added 2.1 preview SDK for text analytics * based on PR commanets changed the number of SDK's to one * fixed test project errors * fixed test project errors * fixed test project errors * fixed test project errors * fixed the log errors * changed the version name and package notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
Rest API PR
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.