[HDInsight] Added support for ESP with AAD-DS #4852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsgouda
suggested changes
Oct 10, 2018
Contributor
dsgouda
left a comment
dsgouda
left a comment
There was a problem hiding this comment.
Looks good apart from versioning
Contributor
There was a problem hiding this comment.
For API version bumps, the nuget major version must be bumped
Contributor
Author
|
I can squash my commits if everything else looks good. |
dsgouda
approved these changes
Oct 11, 2018
Contributor
dsgouda
left a comment
dsgouda
left a comment
There was a problem hiding this comment.
LGTM, please squash the commits
Contributor
Author
|
Apologies, I'm going to add one more commit, where I regenerate with these Swagger changes: Azure/azure-rest-api-specs#4163 I missed these changes earlier, and these changes need to go together with this PR. |
wawon-msft
force-pushed
the
hdiesp
branch
3 times, most recently
from
5ac8412 to
0e0dc2f
Compare
…ed tests, added customization
dsgouda
approved these changes
Oct 12, 2018
Contributor
dsgouda
left a comment
dsgouda
left a comment
There was a problem hiding this comment.
LGTM
@wawon-msft is this good to merge?
Contributor
Author
|
Yep, all the changes I want are in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We made a change to the Swagger spec to add two new parameters in SecurityProfile for cluster creation. This PR contains the regenerated SDK (which was regenerated with a new API version), and re-recorded all tests. There were quite a few minor changes to the SDK due to the API version bump, but I expect this to contain breaking changes.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.