Skip to content

Implement mgmt resource #47944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 70 commits into from
Mar 15, 2025
Merged

Implement mgmt resource #47944

merged 70 commits into from
Mar 15, 2025

Conversation

@live1206
Copy link
Member

@live1206 live1206 commented Jan 23, 2025 •
edited
Loading

  • Resolves Implement ResourceProvdier #47744
  • Resolves Generate OperationSource in Azure plugin #48135
  • Adjust to make MPG have similar file structure as DPG.
    • Put CreateRequest methods from RestClientProvider to ClientProvider
    • Implement client methods in Resource directly
    • Omit RestClientProvider
  • Add test to verify the generation
  • Generated MgmtTypeSpec test can build now
  • Put the logic of extracting resource metadata in emitter, it will be replaced with API from TypeSpec

@github-actions github-actions bot added Client This issue is related to a non-management package CodeGen Issues that relate to code generation labels Jan 23, 2025
@live1206 live1206 mentioned this pull request Feb 6, 2025
Merged
@live1206 live1206 marked this pull request as ready for review February 8, 2025 07:42
m-nash
m-nash reviewed Mar 5, 2025
View reviewed changes
JoshLove-msft
JoshLove-msft reviewed Mar 11, 2025
View reviewed changes
ArcturusZhang
ArcturusZhang reviewed Mar 11, 2025
View reviewed changes
JoshLove-msft
JoshLove-msft reviewed Mar 11, 2025
View reviewed changes
live1206
live1206 commented Mar 13, 2025
View reviewed changes
@live1206 live1206 merged commit 124feb7 into Azure:main Mar 15, 2025
50 checks passed
@live1206 live1206 deleted the implement-mgmt-resource branch March 15, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsquire jsquire jsquire left review comments

@ArcturusZhang ArcturusZhang ArcturusZhang left review comments

@m-nash m-nash m-nash left review comments

Copilot code review Copilot Copilot left review comments

@JoshLove-msft JoshLove-msft JoshLove-msft approved these changes

@jorgerangel-msft jorgerangel-msft Awaiting requested review from jorgerangel-msft jorgerangel-msft is a code owner

@annelo-msft annelo-msft Awaiting requested review from annelo-msft

@christothes christothes Awaiting requested review from christothes christothes is a code owner

@KrzysztofCwalina KrzysztofCwalina Awaiting requested review from KrzysztofCwalina

@tg-msft tg-msft Awaiting requested review from tg-msft

@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978 ArthurMa1978 is a code owner

Assignees

No one assigned

Labels

Client This issue is related to a non-management package CodeGen Issues that relate to code generation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Generate OperationSource in Azure plugin Implement ResourceProvdier

5 participants

@live1206 @jsquire @ArcturusZhang @JoshLove-msft @m-nash