Skip to content

Generate AzureStack Backup.Admin SDK from 2018-09-01 spec#4779

Merged
dsgouda merged 1 commit intoAzure:psSdkJson6from
daozha:certwrap_restore
Sep 21, 2018
Merged

Generate AzureStack Backup.Admin SDK from 2018-09-01 spec#4779
dsgouda merged 1 commit intoAzure:psSdkJson6from
daozha:certwrap_restore

Conversation

@daozha
Copy link
Contributor

@daozha daozha commented Sep 20, 2018 •
edited
Loading

Description

Generate AzureStack Backup.Admin SDK from 2018-09-01 spec
Spec repo PR link: Azure/azure-rest-api-specs#3891

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

daozha
daozha commented Sep 20, 2018
View reviewed changes
src/AzureStack/_metadata/azsadmin_resource-manager_backup.txt Outdated
Copy link
Contributor Author

@daozha daozha Sep 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deathly809 This auto-generated file is empty after running generate.ps1 so I manually copied console output to this file. Please let me know if I didn't do it right.

Copy link
Member

@deathly809 deathly809 Sep 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is weird, it should have filled it in, hopefully someone from the SDK team can chime in on why this would happen.

Copy link
Contributor

@dsgouda dsgouda Sep 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daozha please run msbuild build.proj and regenerate the code. Please squash your commits before updating the PR

Copy link
Contributor Author

@daozha daozha Sep 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works now. Thanks.

deathly809
deathly809 approved these changes Sep 20, 2018
View reviewed changes
Copy link
Member

@deathly809 deathly809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, just verify that the metadata file is correct with the SDK team. That is strange that it was not generated, maybe they have made some changes, idk.

src/AzureStack/_metadata/azsadmin_resource-manager_backup.txt Outdated
Copy link
Member

@deathly809 deathly809 Sep 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is weird, it should have filled it in, hopefully someone from the SDK team can chime in on why this would happen.

dsgouda
dsgouda suggested changes Sep 20, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part

src/AzureStack/_metadata/azsadmin_resource-manager_backup.txt Outdated
Copy link
Contributor

@dsgouda dsgouda Sep 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daozha please run msbuild build.proj and regenerate the code. Please squash your commits before updating the PR

src/AzureStack/Admin/BackupAdmin/Backup.Admin/Properties/AssemblyInfo.cs Outdated
Copy link
Contributor

@dsgouda dsgouda Sep 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Versions less than 1.0.0, both AssemblyVersion and AssemblyFileVersion must be updated

Copy link
Contributor Author

@daozha daozha Sep 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks

dsgouda
dsgouda approved these changes Sep 21, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM will merge on CIs passing

@dsgouda dsgouda merged commit 12f0e61 into Azure:psSdkJson6 Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@deathly809 deathly809 deathly809 approved these changes

@dsgouda dsgouda dsgouda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@daozha @deathly809 @dsgouda