Skip to content

Conversation

@sojain
Copy link

@sojain sojain commented Sep 19, 2018

Description

Stable ga sdk for azure databox, removing unused apis, using final contracts as per the new rest api specs and arm guidelines.
Addition of new fields, correctly marking readme and required fields
Descriptions for enums

Azure rest api spec sign off
Azure/azure-rest-api-specs#3885

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part

@sojain
Copy link
Author

sojain commented Sep 20, 2018

@dsgouda , as per your recommendation I have taken the fixes, can you take a relook. The service changes for the same have already been deployed. If things look ok can you please merge it. We have to release it on ignite 24th September as part of our GA announcement

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the comments was not addressed. Please fix the test csproj and this is good to merge

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM will merge when CIs pass

@dsgouda dsgouda merged commit 891d43b into Azure:psSdkJson6 Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants