-
Notifications
You must be signed in to change notification settings - Fork 5.1k
GA SDK for azure databox #4774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GA SDK for azure databox #4774
Conversation
1) Removal of unused apis 2) SKu Name fixes
dsgouda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for the most part
src/SDKs/DataBox/Management.DataBox/Microsoft.Azure.Management.DataBox.csproj
Show resolved
Hide resolved
|
@dsgouda , as per your recommendation I have taken the fixes, can you take a relook. The service changes for the same have already been deployed. If things look ok can you please merge it. We have to release it on ignite 24th September as part of our GA announcement |
dsgouda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the comments was not addressed. Please fix the test csproj and this is good to merge
dsgouda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM will merge when CIs pass
Description
Stable ga sdk for azure databox, removing unused apis, using final contracts as per the new rest api specs and arm guidelines.
Addition of new fields, correctly marking readme and required fields
Descriptions for enums
Azure rest api spec sign off
Azure/azure-rest-api-specs#3885
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.