New Microsoft.Logic API Version: 2018-07-01-preview#4770
Conversation
|
This introduces a lot of breaking changes. We are doing a version up of the APIs |
refortie
changed the title
refortie
changed the title
| <None Update="TestData\IntegrationAccountAssemblyContent.dll"> | ||
| <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory> | ||
| </None> | ||
| <None Update="TestData\IntegrationAccountCertificate.cer"> |
There was a problem hiding this comment.
Is this an authentication certificate? Not sure if we can check this in
@shahabhijeet FYI
There was a problem hiding this comment.
This was a file that had already existed in the repo to be used in tests. I'm not sure how the tests worked without the file being included. They don't work locally when I don't include it. In general this isn't a cert to anything in particular, just a cert in general.
There was a problem hiding this comment.
@refortie if this is a self-signed cert, this should be fine.
There was a problem hiding this comment.
This is a self signed cert.
| @@ -5,7 +5,7 @@ | |||
|
|
|||
| <PropertyGroup> | |||
| <Description>Microsoft Azure LogicApps Management Library</Description> | |||
| <Version>3.1.0</Version> | |||
| <Version>4.0.0</Version> | |||
| <PackageId>Microsoft.Azure.Management.Logic</PackageId> | |||
| <PackageTags>Microsoft Azure LogicApps management;LogicApps;LogicApps management;</PackageTags> | |||
| <PackageReleaseNotes/> | |||
There was a problem hiding this comment.
Please add PackageReleaseNotes here
There was a problem hiding this comment.
Added, please let me know if the formatting is incorrect
|
Please fix the CI errors reported |
* Change the tests to generate proper session records * Added to the changelog
dsgouda
left a comment
dsgouda
left a comment
There was a problem hiding this comment.
Need an approval from @shahabhijeet regarding the cert
Decrease size of Changelog Remove conditional on warnings as errors
dsgouda
left a comment
dsgouda
left a comment
There was a problem hiding this comment.
LGTM, will let @shahabhijeet take a look and we are good to merge
|
Talked to @shahabhijeet , self signed certificates are acceptable, thanks! |
3 participants
Description
REST spec PRs:
Add new microsoft.logic version
Change some string Microsoft.Logic modeled enums back into enums
Remove default response from Sessions
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.