Skip to content

Adding StorSimple1200Series Azure SDK for Net#4768

Closed
johnemmanuelm wants to merge 7 commits intoAzure:psSdkJson6from
johnemmanuelm:psSdkJson6
Closed

Adding StorSimple1200Series Azure SDK for Net#4768
johnemmanuelm wants to merge 7 commits intoAzure:psSdkJson6from
johnemmanuelm:psSdkJson6

Conversation

@johnemmanuelm
Copy link
Contributor

@johnemmanuelm johnemmanuelm commented Sep 17, 2018

Description


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run msbuild build.proj /p:Scope=StorSimple/Series1200 and commit all the changes generated

@dsgouda
Copy link
Contributor

dsgouda commented Sep 18, 2018

@johnemmanuelm was the code regenerated? There should be a .txt and SdkInfo_*.cs files generated which needs to be checked in

@johnemmanuelm
Copy link
Contributor Author

Hello Deepak, As advised re-generated the client and now those two files are generated. Thanks for the help!

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash commits into a single commit and update the PR
Please confirm no changes have been made to the autogenerated code under Generated directory
Should be good to merge once commits are squashed

@johnemmanuelm
Copy link
Contributor Author

No code under the Generated folder was updated. In fact had to update the rest API spec to generate it again to a pass a certain test case. Azure/azure-rest-api-specs#3951

@dsgouda
Copy link
Contributor

dsgouda commented Sep 20, 2018

Clsoing in favor of #4781

@dsgouda dsgouda closed this Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments