Adding StorSimple1200Series Azure SDK for Net#4768
Closed
johnemmanuelm wants to merge 7 commits intoAzure:psSdkJson6from
Closed
Adding StorSimple1200Series Azure SDK for Net#4768johnemmanuelm wants to merge 7 commits intoAzure:psSdkJson6from
johnemmanuelm wants to merge 7 commits intoAzure:psSdkJson6from
Conversation
dsgouda
suggested changes
Sep 17, 2018
Contributor
dsgouda
left a comment
There was a problem hiding this comment.
Please run msbuild build.proj /p:Scope=StorSimple/Series1200 and commit all the changes generated
src/SDKs/StorSimple/Series1200/StorSimple1200Series.Tests/StorSimple1200Series.Tests.csproj
Outdated
Show resolved
Hide resolved
src/SDKs/StorSimple/Series1200/StorSimple1200Series.Tests/StorSimple1200Series.Tests.csproj
Show resolved
Hide resolved
...s1200/Management.StorSimple1200Series/Microsoft.Azure.Management.StorSimple1200Series.csproj
Show resolved
Hide resolved
src/SDKs/StorSimple/Series1200/Management.StorSimple1200Series/generate.cmd
Outdated
Show resolved
Hide resolved
Contributor
|
@johnemmanuelm was the code regenerated? There should be a .txt and SdkInfo_*.cs files generated which needs to be checked in |
Contributor
Author
|
Hello Deepak, As advised re-generated the client and now those two files are generated. Thanks for the help! |
dsgouda
suggested changes
Sep 20, 2018
Contributor
Author
|
No code under the Generated folder was updated. In fact had to update the rest API spec to generate it again to a pass a certain test case. Azure/azure-rest-api-specs#3951 |
Contributor
|
Clsoing in favor of #4781 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.