Skip to content

Comments

[Storage] add new stroage account kind "FileStorage" and "BlockBlobStorage" and new feature fileaadIntegration #4760

Merged
dsgouda merged 9 commits intoAzure:psSdkJson6from
blueww:newkindfileaad
Sep 17, 2018
Merged

[Storage] add new stroage account kind "FileStorage" and "BlockBlobStorage" and new feature fileaadIntegration #4760
dsgouda merged 9 commits intoAzure:psSdkJson6from
blueww:newkindfileaad

Conversation

@blueww
Copy link
Member

@blueww blueww commented Sep 13, 2018 •
edited
Loading

Description

Add new storage account kind and fileaadintegration support to new api version 2017-08-01

Swagger PR: Azure/azure-rest-api-specs#3864, still in review.
This is generated from my personal repo, send this for an early review, to reduce the risk for release this in Ignite. I will update the SDK when swagger PR merged (should not have much code change).

There's breaking change so upgrade version to 9.0. See details below.

This checklist is used to make sure that common guidelines for a pull request are followed.

  • Please add REST spec PR link to the SDK PR

  • I have read the contribution guidelines.

  • The pull request does not introduce breaking changes.

  • Since the Management Policy not supported in 2018-07-01 (only support on 2018-03-01-preview), I also add it to SDK SRP but with different Opeartion ID (per suggestion of lmazuel). This is breaking.

  • The Global Usage also removed, since will not support in new api versions (as location usage added).

  • I have upgrade SDK version to 9.0 for the breaking change.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

dsgouda
dsgouda suggested changes Sep 13, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run msbuild build.proj /t:build /p:Scope=SDKs\Storage and commit all changes generated

src/SDKs/Storage/Management.Storage/Microsoft.Azure.Management.Storage.csproj
<Version>8.1.0-preview</Version>
<Version>9.0.0-preview</Version>
<PackageTags>Microsoft Azure Storage management;Storage;Storage management;</PackageTags>
<PackageReleaseNotes>See https://aka.ms/asdotnetsdkchangelog for release notes.</PackageReleaseNotes>
Copy link
Contributor

@dsgouda dsgouda Sep 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the changelog

Copy link
Member Author

@blueww blueww Sep 14, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, now change log is updated.

src/SDKs/Storage/Management.Storage/Generated/SdkInfo_StorageManagementClient.cs
new Tuple<string, string, string>("Storage", "StorageAccounts", "2018-03-01-preview"),
new Tuple<string, string, string>("Storage", "Usages", "2018-03-01-preview"),
new Tuple<string, string, string>("Storage", "BlobContainers", "2018-07-01"),
new Tuple<string, string, string>("Storage", "ManagementPolicies", "2018-03-01-preview"),
Copy link
Contributor

@dsgouda dsgouda Sep 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure that one of the services is still preview

Copy link
Member Author

@blueww blueww Sep 14, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, ManagementPolicies feature is not supported in 2017-07-01 api version, and only supported in 2018-03-01-preview. So to keep the feature in SRP SDK, we add it from 2018-03-01-preview api version.

@blueww
Copy link
Member Author

blueww commented Sep 17, 2018

@dsgouda

The swagger PR is merged, and I have updated this PR with merged swagger PR.
Would you please help to review and merge this PR if not other issues asap?
Thanks!

@dsgouda dsgouda merged commit 8f1576f into Azure:psSdkJson6 Sep 17, 2018
@blueww
Copy link
Member Author

blueww commented Sep 18, 2018

@dsgouda

Thanks for the help to review and merge it!

@blueww blueww mentioned this pull request Sep 26, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dsgouda dsgouda dsgouda requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@blueww @dsgouda