Skip to content

Updating customconfig to string#4740

Merged
dsgouda merged 1 commit intoAzure:psSdkJson6from
q3blend:customsearch/customconfig-to-string
Oct 3, 2018
Merged

Updating customconfig to string#4740
dsgouda merged 1 commit intoAzure:psSdkJson6from
q3blend:customsearch/customconfig-to-string

Conversation

@q3blend
Copy link
Contributor

@q3blend q3blend commented Sep 5, 2018 •
edited
Loading

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

spec: Azure/azure-rest-api-specs#3799

@q3blend q3blend force-pushed the customsearch/customconfig-to-string branch 2 times, most recently from 6da5632 to 8c586f1 Compare September 5, 2018 14:48
dsgouda
dsgouda suggested changes Sep 6, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the REST spec is still not merged. We cannot merge this

@q3blend q3blend force-pushed the customsearch/customconfig-to-string branch 2 times, most recently from 64f4dd7 to 8bd84ce Compare September 13, 2018 14:26
dsgouda
dsgouda suggested changes Sep 13, 2018
View reviewed changes
@q3blend q3blend force-pushed the customsearch/customconfig-to-string branch from 9fb1ac1 to 58b82b3 Compare September 26, 2018 11:25
dsgouda
dsgouda suggested changes Sep 26, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please address the 2 comments and squash your commits into a single commit, should be good to merge once addressed

...nitiveServices/dataPlane/Search/BingCustomSearch/BingCustomSearch/Properties/AssemblyInfo.cs Outdated
Copy link
Contributor

@dsgouda dsgouda Sep 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above for AssemblyVersion

@q3blend q3blend force-pushed the customsearch/customconfig-to-string branch from 5972ab8 to 395bfdd Compare September 27, 2018 09:30
@q3blend q3blend force-pushed the customsearch/customconfig-to-string branch from 395bfdd to bf5cd68 Compare September 27, 2018 09:50
@q3blend
Copy link
Contributor Author

q3blend commented Oct 3, 2018

@dsgouda can you merge this? I believe all the comments were addressed

@dsgouda dsgouda merged commit f4b52ac into Azure:psSdkJson6 Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dsgouda dsgouda dsgouda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@q3blend @dsgouda