SignalR - Add more properties to the models, add usage API and complete tests#4728
Merged
dsgouda merged 3 commits intoAzure:psSdkJson6from Sep 6, 2018
Merged
SignalR - Add more properties to the models, add usage API and complete tests#4728dsgouda merged 3 commits intoAzure:psSdkJson6from
dsgouda merged 3 commits intoAzure:psSdkJson6from
Conversation
dsgouda
suggested changes
Aug 31, 2018
src/SDKs/SignalR/Management.SignalR/Microsoft.Azure.Management.SignalR.csproj
Outdated
Show resolved
Hide resolved
src/SDKs/SignalR/Management.SignalR/Microsoft.Azure.Management.SignalR.csproj
Outdated
Show resolved
Hide resolved
Contributor
|
@ArieShout will open a new PR once the stable swagger is checked in, Will reopen this PR if anything changes |
Member
Author
|
Hi @dsgouda , we plan to stay in preview before Ignite and work on stable api-version and SDK release after that. |
Contributor
|
Thanks for confirming. Reopening PR. Will review once changes are pushed |
Member
Author
|
Updated the code according to the review comments and rebased to the latest |
Merged
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The change is based on the spec PR: Azure/azure-rest-api-specs#3686 . We plan to release the version
0.10.0-previewfor the Ignite.Changes:
SignalRInstancemodelSignalRKeysmodelThis checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.