Skip to content

feat(playwrighttesting): Adding stacktrace into error list #47014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 8, 2024
Merged

feat(playwrighttesting): Adding stacktrace into error list #47014

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
192f4b2
Adding stacktrace into error list
puagarwa Nov 7, 2024
231f7b6
add test for null value
puagarwa Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ...ting/Azure.Developer.MicrosoftPlaywrightTesting.TestLogger/src/Processor/DataProcessor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,13 +143,14 @@ public static RawTestResult GetRawResultObject(TestResult? testResultSource)
{
if (testResultSource == null)
return new RawTestResult();
List <MPTError> errors = new();//[testResultSource.ErrorMessage];
List <MPTError> errors = new();
if (testResultSource.ErrorMessage != null)
errors.Add(new MPTError() { message = testResultSource.ErrorMessage });
if (testResultSource.ErrorStackTrace != null)
errors.Add(new MPTError() { message = testResultSource.ErrorStackTrace });
var rawTestResult = new RawTestResult
{
errors = JsonSerializer.Serialize(errors),
stdErr = testResultSource?.ErrorStackTrace ?? string.Empty
errors = JsonSerializer.Serialize(errors)
};
return rawTestResult;
}
Expand Down
19 changes: 17 additions & 2 deletions ...ure.Developer.MicrosoftPlaywrightTesting.TestLogger/tests/Processor/DataProcessorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,22 @@ public void GetRawResultObject_WithNullTestResult_ReturnsRawTestResultWithEmptyE
Assert.AreEqual("[]", result.stdErr);
}

[Test]
public void GetRawResultObject_WithNullErrorStackTrace_ReturnsRawTestResultWithEmptyErrorsAndStdErr()
{
var testResult = new TestResult(new TestCase("Test", new System.Uri("file:///test.cs"), "TestNamespace.TestClass"))
{
ErrorMessage = null,
ErrorStackTrace = null
};

RawTestResult result = DataProcessor.GetRawResultObject(testResult);

Assert.IsNotNull(result);
Assert.AreEqual("[]", result.errors);
Assert.AreEqual("[]", result.stdErr);
}

[Test]
public void GetRawResultObject_WithNonNullTestResult_ReturnsRawTestResultWithErrorsAndStdErr()
{
Expand All @@ -172,8 +188,7 @@ public void GetRawResultObject_WithNonNullTestResult_ReturnsRawTestResultWithErr
RawTestResult result = DataProcessor.GetRawResultObject(testResult);

Assert.IsNotNull(result);
Assert.AreEqual("[{\"message\":\"An error occurred\"}]", result.errors);
Assert.AreEqual("Error stack trace", result.stdErr);
Assert.AreEqual("[{\"message\":\"An error occurred\"},{\"message\":\"Error stack trace\"}]", result.errors);
}
}
}