EventGrid Dataplane SDK: Re-generated SDK to include new event types + updated corresponding unit tests

[kalyanaj]

Description

EventGrid Dataplane SDK: Re-generated SDK to include new event types + updated corresponding unit tests. Swagger updates that trigger this are:

Azure/azure-rest-api-specs#3504
Azure/azure-rest-api-specs#3448
Azure/azure-rest-api-specs#3174

---

This checklist is used to make sure that common guidelines for a pull request are followed.

• Please add REST spec PR link to the SDK PR
• I have read the contribution guidelines.
• The pull request does not introduce breaking changes.
  Note: For the two IoT events (DeviceCreated/DeviceDeleted), the IoT team has removed two properties from the data schema. IoT events for EventGrid is currently in preview, hence this change has been done before they GA their EventGrid support.

General Guidelines

• Title of the pull request is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

• Pull request includes test coverage for the included changes.

SDK Generation Guidelines

• If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
• The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
• The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

[kalyanaj]

Question to the reviewer:

This model is based on the swagger definition in https://github.com/Azure/azure-rest-api-specs/blob/master/specification/eventgrid/data-plane/Microsoft.Media/stable/2018-01-01/MediaServices.json. There have been no changes in this swagger since May 18, hence I am looking to understand why this got re-generated (new autorest behavior?). Can you please help me understand this?

[dsgouda]

@kalyanaj The behavior per se would be the same for both ends, i.e., the REST service sending/receiving this enum value vs the client.
Its a better/cleaner implementation of extensible enum that we released over the past few months. We do have some flags available to revert to the legacy implementation.

[kalyanaj]

Thanks @dsgouda for the info!

[dsgouda]

Looks good for the most part

[dsgouda]

Removing properties is a breaking change, please bump the major version number for nuget package

[kalyanaj]

OK, updating the version number in the csproj to 2.0.0. Also, updating the AssemblyFileVersion to 2.0.0.0 and AssemblyVersion to 2.0.0.0. Please let me know in case that's not what you meant...

[dsgouda]

Yep, that is what I meant, here is an example

[kalyanaj]

Thanks, I have updated this in the latest commit.

[dsgouda]

@kalyanaj The behavior per se would be the same for both ends, i.e., the REST service sending/receiving this enum value vs the client.
Its a better/cleaner implementation of extensible enum that we released over the past few months. We do have some flags available to revert to the legacy implementation.

[kalyanaj]

Thanks @dsgouda for the review. If you have any additional comments, please let me know. If it looks good, can you please merge this? We are looking to release this tomorrow.

[dsgouda]

LGTM