Prepare for release of Microsoft.Azure.Batch Data Plane 9.0#4689
Prepare for release of Microsoft.Azure.Batch Data Plane 9.0#4689dsgouda merged 11 commits intoAzure:psSdkJson6from
Conversation
- Requests whose default timeouts are 2m should have a client side timeout
longer than 2m.
- The underlying server bug/behavior which caused us to need to do this has been fixed
in the latest REST API version.
- This allows callers to bypass a superfluous GetFileProperties call
if they're really interested in performance when downloading files.
- Nor do we plan to.
There was a problem hiding this comment.
Is the REST spec merged? We cannot accept this PR until the spec is merged to Azure master
There was a problem hiding this comment.
It's already merged I just generated from a private branch from before and haven't updated this file.
I can regenerate it if you want.
There was a problem hiding this comment.
That would be much appreciated. If you can pull down latest changes and run msbuild build.proj before regenerating that'd be even better
- Update SDK version to 9.0. - Update changelog.
matthchr
force-pushed
the
feature/batch-sdk-9.0
branch
from
b3f207f to
689a258
Compare
|
@dsgouda - I did as you asked and regenerated -- can you merge this? |
There was a problem hiding this comment.
Please run msbuild build.proj /t:build /p:Scope=SDKs\Batch\DataPlane\Azure.Batch and commit the changes generated to .props file here
If you do not see any changes, simply replace _2018-03-01.6.1; with _2018-08-01.7.0; in the file
|
Looks great apart from a minor comment |
dsgouda
left a comment
dsgouda
left a comment
There was a problem hiding this comment.
LGTM will merge when CIs pass
|
@dsgouda - CI passed |
3 participants
Description
Update the Azure Batch C# SDK with support for REST API version 2018-08-01.7.0
REST API Spec PR: Azure/azure-rest-api-specs#3657
Note that this is a breaking change.
In addition to various other improvements, this PR fixes: #4602, #4475, #2538
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.