Skip to content

Generating LUIS SDK for updated specification file#4638

Merged
dsgouda merged 2 commits intoAzure:psSdkJson6from
mohabghanem:psSdkJson6
Aug 9, 2018
Merged

Generating LUIS SDK for updated specification file#4638
dsgouda merged 2 commits intoAzure:psSdkJson6from
mohabghanem:psSdkJson6

Conversation

@mohabghanem
Copy link
Contributor

@mohabghanem mohabghanem commented Aug 6, 2018 •
edited
Loading

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@dsgouda
Copy link
Contributor

dsgouda commented Aug 7, 2018

@mohabghanem please link the related REST spec PR

dsgouda
dsgouda suggested changes Aug 7, 2018
View reviewed changes
src/SDKs/CognitiveServices/dataPlane/Language/LUIS/Runtime/Generated/Models/EntityModel.cs Outdated
Copy link
Contributor

@dsgouda dsgouda Aug 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change. Please bump the major version number here Also, update the PackageReleaseNotes accordingly

Copy link
Contributor

@dsgouda dsgouda Aug 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the AssemblyInfo here based on these version updates.

Copy link
Contributor Author

@mohabghanem mohabghanem Aug 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsgouda where to update the PackageReleaseNotes?

dsgouda
dsgouda suggested changes Aug 7, 2018
View reviewed changes
src/SDKs/CognitiveServices/dataPlane/Language/LUIS/Runtime/Properties/AssemblyInfo.cs Outdated
Copy link
Contributor

@dsgouda dsgouda Aug 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the AssemblyFileVersion too

...rvices/dataPlane/Language/LUIS/Runtime/Microsoft.Azure.CognitiveServices.LUIS.Runtime.csproj Outdated
Copy link
Contributor

@dsgouda dsgouda Aug 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PackageReleaseNotes here

Copy link
Contributor Author

@mohabghanem mohabghanem Aug 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsgouda what should be in the PackageReleaseNotes ?

Copy link
Contributor

@dsgouda dsgouda Aug 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What changes you are planning to release in this version. Please check the
"Changes in this release:" section

@mohabghanem
Copy link
Contributor Author

mohabghanem commented Aug 7, 2018

@dsgouda please review

dsgouda
dsgouda suggested changes Aug 7, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great apart from a minor comment.

...es/dataPlane/Language/LUIS/Authoring/Microsoft.Azure.CognitiveServices.LUIS.Authoring.csproj Outdated
Copy link
Contributor

@dsgouda dsgouda Aug 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PackageReleaseNotes must be updated

Copy link
Contributor Author

@mohabghanem mohabghanem Aug 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsgouda I edited the package release notes. But I do not know what else to add, because the only change in this PR is customizing the endpoint

dsgouda
dsgouda approved these changes Aug 7, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda
Copy link
Contributor

dsgouda commented Aug 7, 2018

Will merge on CIs passing

yangyuan
yangyuan approved these changes Aug 7, 2018
View reviewed changes
...rvices/dataPlane/Language/LUIS/Runtime/Microsoft.Azure.CognitiveServices.LUIS.Runtime.csproj Outdated
Copy link
Member

@yangyuan yangyuan Aug 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest to use below description: (The reason is we may not change Azure Portal quickly, so better in here (as well as documents) we emphasize that the Endpoint should only contains protocol and hostname)

  1. Supported customizing service endpoints by assigning the endpoint string to LUISRuntimeClient.Endpoint. The endpoint string can be found on Azure Portal, it should contain only protocol and hostname, for example: https://westus.api.cognitive.microsoft.com.
    2....

@mohabghanem
Copy link
Contributor Author

mohabghanem commented Aug 8, 2018

@dsgouda @yangyuan I get the build error 'Build step 'Build a Visual Studio project or solution using MSBuild' marked build as failure' from the automated build. However builds and tests ran successfully on my local machine before pushing. Any clues on what may be causing this problem it?

yangyuan
yangyuan reviewed Aug 8, 2018
View reviewed changes
...es/dataPlane/Language/LUIS/Authoring/Microsoft.Azure.CognitiveServices.LUIS.Authoring.csproj Outdated
Copy link
Member

@yangyuan yangyuan Aug 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TTypo :)

Copy link
Member

@yangyuan yangyuan Aug 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Authoring. The client name should be LUISAuthoringClient

@yangyuan
Copy link
Member

yangyuan commented Aug 8, 2018

@mohabghanem I have no clue about that build error.
Can you try rebase to latest Azure:psSdkJson6? If CI do merge before build, then the error might be cause by recent psSdkJson6 changes.

@mohabghanem
Copy link
Contributor Author

mohabghanem commented Aug 9, 2018

@yangyuan @dsgouda The tests are now passing. Please review.

dsgouda
dsgouda approved these changes Aug 9, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit fa8ec37 into Azure:psSdkJson6 Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yangyuan yangyuan yangyuan approved these changes

+1 more reviewer

@dsgouda dsgouda dsgouda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mohabghanem @dsgouda @yangyuan