[Do Not Merge] RecoveryServices.Backup update for latest release #4613

sumitmal · 2018-07-31T14:19:31Z

Description

Azure/azure-rest-api-specs#3395

This checklist is used to make sure that common guidelines for a pull request are followed.

Please add REST spec PR link to the SDK PR
I have read the contribution guidelines.
The pull request does not introduce breaking changes.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

SDK Generation Guidelines

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

This reverts commit 0519fee.

This reverts commit 49135af.

azuresdkci · 2018-07-31T14:23:05Z

Can one of the admins verify this patch?

dsgouda

Please regenerate the code using the generate.ps1 script here
and commit all changes.

dsgouda · 2018-07-31T16:32:07Z

src/SDKs/RecoveryServices.Backup/Management.RecoveryServices.Backup/Generated/Models/MabJob.cs

+        /// 'GenericContainer'
        /// </summary>
        [JsonProperty(PropertyName = "mabServerType")]
-        public string MabServerType { get; set; }


These are breaking changes, please bump the assembly version to 3.1.0-preview

dsgouda · 2018-07-31T16:32:59Z

src/SDKs/RecoveryServices.Backup/Management.RecoveryServices.Backup/Properties/AssemblyInfo.cs


-[assembly: AssemblyVersion("3.0.0.0")]
-[assembly: AssemblyFileVersion("3.0.0.0")]
+[assembly: AssemblyVersion("3.0.0.1")]


AssemblyVersion remains the same, AssemblyFileVersion must be updated

dsgouda · 2018-07-31T16:34:10Z

...Management.RecoveryServices.Backup/Microsoft.Azure.Management.RecoveryServices.Backup.csproj

+		<Version>3.0.1-preview</Version>
 		<AssemblyName>Microsoft.Azure.Management.RecoveryServices.Backup</AssemblyName>
 		<PackageTags>Recoveryservices;Backup;</PackageTags>
 		<PackageReleaseNotes/>


Please add meaningful information in the PackageReleaseNotes similar to this

dsgouda · 2018-07-31T17:55:08Z

@sumitmal Please join the Azure org on github here to trigger the CI builds

dsgouda · 2018-08-08T20:38:13Z

@sumitmal Please join the Azure org as suggested. Will close the PR by next week if there is no activity

Generated using Generate.ps1

sumitmal · 2018-08-09T06:42:08Z

Resolved following comments @dsgouda

Bumped the minor version
Generated.ps1 used to generate
Update package release notes.
Joined Azure.

dsgouda

Looks great apart from the one comment

dsgouda · 2018-08-09T16:39:07Z

src/SDKs/RecoveryServices.Backup/Management.RecoveryServices.Backup/Properties/AssemblyInfo.cs


-[assembly: AssemblyVersion("3.0.0.0")]
-[assembly: AssemblyFileVersion("3.0.0.0")]
+[assembly: AssemblyVersion("3.1.0.0")]


Please keep the AssemblyVersion unchanged here

sumitmal · 2018-08-09T16:45:52Z

@dsgouda done

dsgouda

LGTM

dsgouda · 2018-08-09T16:47:38Z

Will merge on CIs passing

shahabhijeet

Ignore the fact that this was a preview package.
Looks good.

sumitmal added 5 commits July 27, 2018 22:48

SDK 1806 update

0519fee

Incrementing the version

49135af

Revert "SDK 1806 update"

af80a30

This reverts commit 0519fee.

Revert "Incrementing the version"

4fc0aca

This reverts commit 49135af.

RecoveryServices.Backup release

2c8e0d3

dsgouda suggested changes Jul 31, 2018

View reviewed changes

dsgouda added the Changes Requested label Jul 31, 2018

Recovery services backup 1807

7d81c59

Generated using Generate.ps1

dsgouda suggested changes Aug 9, 2018

View reviewed changes

incorporating feedback

6c33923

dsgouda approved these changes Aug 9, 2018

View reviewed changes

shahabhijeet added the Do Not Merge label Aug 20, 2018

shahabhijeet changed the title ~~RecoveryServices.Backup update for latest release~~ [Do Not Merge] RecoveryServices.Backup update for latest release Aug 20, 2018

shahabhijeet approved these changes Aug 20, 2018

View reviewed changes

shahabhijeet removed the Do Not Merge label Aug 20, 2018

shahabhijeet merged commit 73151e3 into Azure:psSdkJson6 Aug 20, 2018

[Do Not Merge] RecoveryServices.Backup update for latest release #4613

[Do Not Merge] RecoveryServices.Backup update for latest release #4613

Uh oh!

Conversation

sumitmal commented Jul 31, 2018

Description

Uh oh!

azuresdkci commented Jul 31, 2018

Uh oh!

dsgouda left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dsgouda commented Jul 31, 2018

Uh oh!

dsgouda commented Aug 8, 2018

Uh oh!

sumitmal commented Aug 9, 2018

Uh oh!

dsgouda left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sumitmal commented Aug 9, 2018

Uh oh!

dsgouda left a comment

Choose a reason for hiding this comment

Uh oh!

dsgouda commented Aug 9, 2018

Uh oh!

shahabhijeet left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants