Skip to content

[Datafactory] Updated UserProperties model in Activities#4582

Merged
shahabhijeet merged 4 commits intoAzure:psSdkJson6from
hvermis:psSdkJson6
Jul 24, 2018
Merged

[Datafactory] Updated UserProperties model in Activities#4582
shahabhijeet merged 4 commits intoAzure:psSdkJson6from
hvermis:psSdkJson6

Conversation

@hvermis
Copy link
Contributor

@hvermis hvermis commented Jul 24, 2018

Description


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Copy link
Contributor

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change and should be reflected in the version.
You have a download base of ~1600 as of now for V1.0.0.
With this change you are essentially breaking all of them.
Remove addtionalProperties could have been discussed if it falls under breaking change as it's still a optional parameter, but changing data type of userProperties is for user a breaking change and should be treated according.
Also PackageRelease notes should reflect accordingly.
The code change seems fine.
You need to update version to 2.0.0 and mention the breaking change in the package release notes.

@shahabhijeet
Copy link
Contributor

@hvermis can you add the link to the spec PR that was merged for this change.

@hvermis
Copy link
Contributor Author

hvermis commented Jul 24, 2018

We didn't mean to remove additionaProperties, bringing them back.
The user properties is a new feature not used by customers yet, but we will add them as breaking change.

@hvermis
Copy link
Contributor Author

hvermis commented Jul 24, 2018

@hvermis
Copy link
Contributor Author

hvermis commented Jul 24, 2018

@shahabhijeet The spec PR-s are merged, and I updated according to your comments

@shahabhijeet shahabhijeet merged commit 8394554 into Azure:psSdkJson6 Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants