[Datafactory] Updated UserProperties model in Activities#4582
[Datafactory] Updated UserProperties model in Activities#4582shahabhijeet merged 4 commits intoAzure:psSdkJson6from hvermis:psSdkJson6
Conversation
shahabhijeet
left a comment
There was a problem hiding this comment.
This is a breaking change and should be reflected in the version.
You have a download base of ~1600 as of now for V1.0.0.
With this change you are essentially breaking all of them.
Remove addtionalProperties could have been discussed if it falls under breaking change as it's still a optional parameter, but changing data type of userProperties is for user a breaking change and should be treated according.
Also PackageRelease notes should reflect accordingly.
The code change seems fine.
You need to update version to 2.0.0 and mention the breaking change in the package release notes.
|
@hvermis can you add the link to the spec PR that was merged for this change. |
|
We didn't mean to remove additionaProperties, bringing them back. |
|
Azure spec PR-s |
|
@shahabhijeet The spec PR-s are merged, and I updated according to your comments |
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.