Skip to content

Conversation

@jeji1101
Copy link

Description


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@vl8163264128
Copy link
Contributor

#sign-off

@jeji1101 jeji1101 changed the title Jeji/sdkforskill Add Cognitive Search Jul 19, 2018
@jeji1101 jeji1101 changed the title Add Cognitive Search Add Cognitive Skillset Operations Jul 19, 2018
@dsgouda
Copy link
Contributor

dsgouda commented Jul 19, 2018

@jeji1101 please reference the rest spec PR

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please regenerate the code using generate.ps1 and commit all changes

@jeji1101
Copy link
Author

The corresponding swagger spec PR is: Azure/azure-rest-api-specs#3386. Thanks.

@dsgouda
Copy link
Contributor

dsgouda commented Jul 20, 2018

@azuresdkci Retest this please

@dsgouda
Copy link
Contributor

dsgouda commented Jul 20, 2018

@jeji1101 please pull latest changes from upstream and update the PR

@dsgouda
Copy link
Contributor

dsgouda commented Jul 23, 2018

@brjohnstmsft could you please update the search-preview branch with the latest psSdkJson6 in order to fix these build issues

@dsgouda
Copy link
Contributor

dsgouda commented Jul 30, 2018

@azuresdkci Retest this please

@dsgouda
Copy link
Contributor

dsgouda commented Jul 30, 2018

@jeji1101 Please update your branch with remote search-preview and update the PR

@brjohnstmsft brjohnstmsft changed the title Add Cognitive Skillset Operations [DO NOT MERGE] Add Cognitive Skillset Operations Jul 30, 2018
@brjohnstmsft
Copy link
Member

@dsgouda I've updated the branch. Please do not merge until I've had a chance to review it.

@dsgouda
Copy link
Contributor

dsgouda commented Jul 30, 2018

@jeji1101 would you like to close this in favor of #4609

@brjohnstmsft
Copy link
Member

@dsgouda @jeji1101 Fine by me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants