Skip to content

Batch AI .Net SDKs related to swagger typo fix#4553

Closed
llidev wants to merge 3 commits intoAzure:psSdkJson6from
llidev:psSdkJson6
Closed

Batch AI .Net SDKs related to swagger typo fix#4553
llidev wants to merge 3 commits intoAzure:psSdkJson6from
llidev:psSdkJson6

Conversation

@llidev
Copy link
Contributor

@llidev llidev commented Jul 17, 2018

Description


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@llidev
Copy link
Contributor Author

llidev commented Jul 17, 2018

Swagger Spec PR: Azure/azure-rest-api-specs#3328

@dsgouda
Copy link
Contributor

dsgouda commented Jul 18, 2018

@lliimsft please update the branch
also please confirm you wish to bump the major version for this package

@llidev
Copy link
Contributor Author

llidev commented Jul 20, 2018

I confirmed that we wish to bump the major version for this package

@dsgouda
Copy link
Contributor

dsgouda commented Jul 20, 2018

@lliimsft LGTM please merge all commits into a single commit and update the PR, will merge once done

@dsgouda
Copy link
Contributor

dsgouda commented Aug 8, 2018

@lliimsft Please address comments soon. WIll close the PR by end of week if there is no activity

@shahabhijeet
Copy link
Contributor

@lliimsft please open a new PR with all the comments addressed. Especially have your commit history clean.
We have lots of issues with merge commits and so we discourage not to have them.
This PR has been open for a while and will be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants