[Compute] Fixing RunCommand API and adding missing ScaleSet Properties#4549
Merged
dsgouda merged 1 commit intoAzure:psSdkJson6from Jul 19, 2018
Merged
[Compute] Fixing RunCommand API and adding missing ScaleSet Properties#4549dsgouda merged 1 commit intoAzure:psSdkJson6from
dsgouda merged 1 commit intoAzure:psSdkJson6from
Conversation
Contributor
Author
|
I didn't update the version because the existing version (21.0.0) is not yet published to nuget. |
Contributor
Author
|
The build failure doesn't seem to be related with this PR. Could you check why the build fails? Thanks. |
Contributor
Author
|
Please review this PR. I need this to fix RunCommand issue for Powershell. |
dsgouda
suggested changes
Jul 17, 2018
Contributor
dsgouda
left a comment
dsgouda
left a comment
There was a problem hiding this comment.
Looks good for the most part, please merge the 2 commits into a single one and we are good to merge
hyonholee
force-pushed
the
runcommand_fix
branch
from
5bcbe26 to
e03dc2d
Compare
Contributor
Author
|
@dsgouda now I have only one commit. Thanks. |
Contributor
|
@hyonholee you probably need to pull down the latest changes and update the PR again |
hyonholee
force-pushed
the
runcommand_fix
branch
from
52ea250 to
cd830a2
Compare
Contributor
Author
|
@dsgouda the failed test doesn't seem to be related with my PR. Can you retry it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't update the version because the existing version (21.0.0) is not yet published to nuget.
Azure/azure-rest-api-specs#3364
Azure/azure-rest-api-specs#3406
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.