Skip to content

Batch AI .Net SDKs related to swagger typo fix#4513

Closed
llidev wants to merge 1 commit intoAzure:psSdkJson6from
llidev:psSdkJson6
Closed

Batch AI .Net SDKs related to swagger typo fix#4513
llidev wants to merge 1 commit intoAzure:psSdkJson6from
llidev:psSdkJson6

Conversation

@llidev
Copy link
Contributor

@llidev llidev commented Jun 29, 2018

Description


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@llidev
Copy link
Contributor Author

llidev commented Jun 29, 2018

Swagger Spec PR: Azure/azure-rest-api-specs#3328

@dsgouda
Copy link
Contributor

dsgouda commented Jun 29, 2018

This is a breaking change, we need to investigate

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked to @sarangan12 and confirmed that the breaking changes were notified in REST spec PR

<PackageId>Microsoft.Azure.Management.BatchAI</PackageId>
<Description>Provides management capabilities for Azure Batch AI.</Description>
<Version>2.0.0</Version>
<Version>2.0.1</Version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the enum values are being renamed here, it is a breaking change. Please update the major version number here

@shahabhijeet
Copy link
Contributor

@lliimsft please let us know if you still would like to merge this changes. We will close this PR next week if we do not see any activity.

@dsgouda
Copy link
Contributor

dsgouda commented Jul 6, 2018

Talked to @lliimsft offline, this needs to be discussed and a new PR will be opened when a decision is made by the RP

@dsgouda dsgouda closed this Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants