Batch AI .Net SDKs related to swagger typo fix#4513
Closed
llidev wants to merge 1 commit intoAzure:psSdkJson6from
llidev:psSdkJson6
Closed
Batch AI .Net SDKs related to swagger typo fix#4513llidev wants to merge 1 commit intoAzure:psSdkJson6from llidev:psSdkJson6
llidev wants to merge 1 commit intoAzure:psSdkJson6from
llidev:psSdkJson6
Conversation
Contributor
Author
|
Swagger Spec PR: Azure/azure-rest-api-specs#3328 |
Contributor
|
This is a breaking change, we need to investigate |
dsgouda
suggested changes
Jul 2, 2018
Contributor
dsgouda
left a comment
There was a problem hiding this comment.
Talked to @sarangan12 and confirmed that the breaking changes were notified in REST spec PR
| <PackageId>Microsoft.Azure.Management.BatchAI</PackageId> | ||
| <Description>Provides management capabilities for Azure Batch AI.</Description> | ||
| <Version>2.0.0</Version> | ||
| <Version>2.0.1</Version> |
Contributor
There was a problem hiding this comment.
Since the enum values are being renamed here, it is a breaking change. Please update the major version number here
Contributor
|
@lliimsft please let us know if you still would like to merge this changes. We will close this PR next week if we do not see any activity. |
Contributor
|
Talked to @lliimsft offline, this needs to be discussed and a new PR will be opened when a decision is made by the RP |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.