Add resolutionPolicy property to VirtualNetworkLink resource in privatedns #45022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
API change check API changes are not detected in this pull request. |
pranavpnair
requested review from
ArcturusZhang,
ArthurMa1978,
archerzz and
jsquire
as code owners
rahisshaikh
reviewed
Sep 5, 2024
rahisshaikh
left a comment
rahisshaikh
left a comment
There was a problem hiding this comment.
PrivateDNS team has reviewed and signed off on the change
archerzz
approved these changes
Sep 5, 2024
Member
archerzz
left a comment
archerzz
left a comment
There was a problem hiding this comment.
Generally good. Just one minor comment regarding the test case.
sdk/privatedns/Azure.ResourceManager.PrivateDns/tests/Scenario/PrivateDnsTests.cs
Outdated
Show resolved
Hide resolved
sdk/privatedns/Azure.ResourceManager.PrivateDns/tests/Scenario/PrivateDnsTests.cs
Outdated
Show resolved
Hide resolved
sdk/privatedns/Azure.ResourceManager.PrivateDns/tests/Scenario/PrivateDnsTests.cs
Outdated
Show resolved
Hide resolved
ArthurMa1978
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.
PR Description
A new (enum) property called NxDomainRedirect is being added to VirtualNetworkLink resource.
The property was already added to swagger in July. The PR can be found here: Azure/azure-rest-api-specs#29470
The default API version for PrivateDNS functions has also been updated to the latest available version: 2024-06-01.
Change owners: [email protected], [email protected]