Update tests for Policy SDK version 2018-03-01#4499
Update tests for Policy SDK version 2018-03-01#4499dsgouda merged 5 commits intoAzure:psSdkJson6from
Conversation
Remove duplicate type created when ManagementGroup API was removed from the rest of the resources SDK Refactor and greatly improve policy live/scenario tests Add many new policy live tests Save session records from recorded tests
|
@mentat9 Please fix the failing managementgroup tests. You may have to re-record the tests |
Is it normal to do a regeneration when there is no swagger change? |
|
@mentat9 I assumed you were adding changes to the SDK too. Please disregard the regeneration |
Thing is, those aren't my tests and they don't record successfully on my machine. Playback, OTOH is working fine, so I don't understand why they aren't working on the server. Any ideas? |
Rerecord policy tests on different subscription
|
@dsgouda, the tests have been re-recorded, but they still fail in the server build. Neither I nor Raj (the test owner) know how to fix this break. These tests all run fine locally in both of our dev environments. Can you help? |
|
@mentat9 taking a look |
|
@dsgouda did you learn anything about the break? |
|
Tried re-running the build without success, will have to debug myself. @shahabhijeet could you take a look at it too? |
|
@rajshah11 can you review this PR. |
rajshah11
left a comment
There was a problem hiding this comment.
@dsgouda @shahabhijeet LGTM. I also ran the tests again and the changes made to ManagementGroups.Test project were fine. The build ran fine locally. Not sure why the build is failing here though.
|
I think I might have figured it out. It looks like someone left behind some old unused test recordings under:
When the management group SDK was removed from the resources SDK, these should have been deleted. I'm guessing server test discovery is finding these and trying to run them, but they are outdated. Hopefully, that is the problem. If so, I don't understand why my build was the first to break. I would have expected every build since the MG code was removed from the Resource SDK should have broken. |
|
I have no idea what this failure in the Travis build means:
But I've seen it before and it had nothing to do with my PR: it was something broken in the build environment. @dsgouda (or someone), can you force a retry on the Travis build? |
Description
NOTE: This update does NOT include a swagger change. Consequently, the below boxes for updating generate.cmd/generate.ps1 and project versions are not checked.
This update adds tests to cover the most recent update to the Governance Policy swagger.
Current REST spec for Governance Policy is here:
https://github.com/Azure/azure-rest-api-specs/tree/master/specification/resources/resource-manager/Microsoft.Authorization/stable/2018-03-01
Most recent changes were in this PR:
Azure/azure-rest-api-specs#3032
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.