Skip to content

CSharp SDK - June 2018 #4488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsgouda merged 1 commit into from Jul 13, 2018
Merged

CSharp SDK - June 2018 #4488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
5 changes: 2 additions & 3 deletions ...ryServices.Backup/Management.RecoveryServices.Backup/Generated/BackupEnginesOperations.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
// <auto-generated>
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for
// license information.
//
// Code generated by Microsoft (R) AutoRest Code Generator.
// Changes may cause incorrect behavior and will be lost if the code is
// regenerated.
// </auto-generated>

namespace Microsoft.Azure.Management.RecoveryServices.Backup
{
using Microsoft.Azure;
using Microsoft.Azure.Management;
using Microsoft.Azure.Management.RecoveryServices;
using Microsoft.Rest;
using Microsoft.Rest.Azure;
using Microsoft.Rest.Azure.OData;
Expand Down
9 changes: 4 additions & 5 deletions ....Backup/Management.RecoveryServices.Backup/Generated/BackupEnginesOperationsExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
// <auto-generated>
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for
// license information.
//
// Code generated by Microsoft (R) AutoRest Code Generator.
// Changes may cause incorrect behavior and will be lost if the code is
// regenerated.
// </auto-generated>

namespace Microsoft.Azure.Management.RecoveryServices.Backup
{
using Microsoft.Azure;
using Microsoft.Azure.Management;
using Microsoft.Azure.Management.RecoveryServices;
using Microsoft.Rest;
using Microsoft.Rest.Azure;
using Microsoft.Rest.Azure.OData;
Expand Down Expand Up @@ -45,7 +44,7 @@ public static partial class BackupEnginesOperationsExtensions
/// </param>
public static IPage<BackupEngineBaseResource> List(this IBackupEnginesOperations operations, string vaultName, string resourceGroupName, ODataQuery<BMSBackupEnginesQueryObject> odataQuery = default(ODataQuery<BMSBackupEnginesQueryObject>), string skipToken = default(string))
{
return ((IBackupEnginesOperations)operations).ListAsync(vaultName, resourceGroupName, odataQuery, skipToken).GetAwaiter().GetResult();
return operations.ListAsync(vaultName, resourceGroupName, odataQuery, skipToken).GetAwaiter().GetResult();
}

/// <summary>
Expand Down Expand Up @@ -103,7 +102,7 @@ public static partial class BackupEnginesOperationsExtensions
/// </param>
public static BackupEngineBaseResource Get(this IBackupEnginesOperations operations, string vaultName, string resourceGroupName, string backupEngineName, ODataQuery<BMSBackupEngineQueryObject> odataQuery = default(ODataQuery<BMSBackupEngineQueryObject>), string skipToken = default(string))
{
return ((IBackupEnginesOperations)operations).GetAsync(vaultName, resourceGroupName, backupEngineName, odataQuery, skipToken).GetAwaiter().GetResult();
return operations.GetAsync(vaultName, resourceGroupName, backupEngineName, odataQuery, skipToken).GetAwaiter().GetResult();
}

/// <summary>
Expand Down
5 changes: 2 additions & 3 deletions ...overyServices.Backup/Management.RecoveryServices.Backup/Generated/BackupJobsOperations.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
// <auto-generated>
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for
// license information.
//
// Code generated by Microsoft (R) AutoRest Code Generator.
// Changes may cause incorrect behavior and will be lost if the code is
// regenerated.
// </auto-generated>

namespace Microsoft.Azure.Management.RecoveryServices.Backup
{
using Microsoft.Azure;
using Microsoft.Azure.Management;
using Microsoft.Azure.Management.RecoveryServices;
using Microsoft.Rest;
using Microsoft.Rest.Azure;
using Microsoft.Rest.Azure.OData;
Expand Down
7 changes: 3 additions & 4 deletions ...ces.Backup/Management.RecoveryServices.Backup/Generated/BackupJobsOperationsExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
// <auto-generated>
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for
// license information.
//
// Code generated by Microsoft (R) AutoRest Code Generator.
// Changes may cause incorrect behavior and will be lost if the code is
// regenerated.
// </auto-generated>

namespace Microsoft.Azure.Management.RecoveryServices.Backup
{
using Microsoft.Azure;
using Microsoft.Azure.Management;
using Microsoft.Azure.Management.RecoveryServices;
using Microsoft.Rest;
using Microsoft.Rest.Azure;
using Microsoft.Rest.Azure.OData;
Expand Down Expand Up @@ -44,7 +43,7 @@ public static partial class BackupJobsOperationsExtensions
/// </param>
public static IPage<JobResource> List(this IBackupJobsOperations operations, string vaultName, string resourceGroupName, ODataQuery<JobQueryObject> odataQuery = default(ODataQuery<JobQueryObject>), string skipToken = default(string))
{
return ((IBackupJobsOperations)operations).ListAsync(vaultName, resourceGroupName, odataQuery, skipToken).GetAwaiter().GetResult();
return operations.ListAsync(vaultName, resourceGroupName, odataQuery, skipToken).GetAwaiter().GetResult();
}

/// <summary>
Expand Down
5 changes: 2 additions & 3 deletions ...s.Backup/Management.RecoveryServices.Backup/Generated/BackupOperationResultsOperations.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
// <auto-generated>
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for
// license information.
//
// Code generated by Microsoft (R) AutoRest Code Generator.
// Changes may cause incorrect behavior and will be lost if the code is
// regenerated.
// </auto-generated>

namespace Microsoft.Azure.Management.RecoveryServices.Backup
{
using Microsoft.Azure;
using Microsoft.Azure.Management;
using Microsoft.Azure.Management.RecoveryServices;
using Microsoft.Rest;
using Microsoft.Rest.Azure;
using Models;
Expand Down
5 changes: 2 additions & 3 deletions ...anagement.RecoveryServices.Backup/Generated/BackupOperationResultsOperationsExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
// <auto-generated>
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for
// license information.
//
// Code generated by Microsoft (R) AutoRest Code Generator.
// Changes may cause incorrect behavior and will be lost if the code is
// regenerated.
// </auto-generated>

namespace Microsoft.Azure.Management.RecoveryServices.Backup
{
using Microsoft.Azure;
using Microsoft.Azure.Management;
using Microsoft.Azure.Management.RecoveryServices;
using Microsoft.Rest;
using Microsoft.Rest.Azure;
using Models;
Expand Down
5 changes: 2 additions & 3 deletions ....Backup/Management.RecoveryServices.Backup/Generated/BackupOperationStatusesOperations.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
// <auto-generated>
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for
// license information.
//
// Code generated by Microsoft (R) AutoRest Code Generator.
// Changes may cause incorrect behavior and will be lost if the code is
// regenerated.
// </auto-generated>

namespace Microsoft.Azure.Management.RecoveryServices.Backup
{
using Microsoft.Azure;
using Microsoft.Azure.Management;
using Microsoft.Azure.Management.RecoveryServices;
using Microsoft.Rest;
using Microsoft.Rest.Azure;
using Models;
Expand Down
5 changes: 2 additions & 3 deletions ...nagement.RecoveryServices.Backup/Generated/BackupOperationStatusesOperationsExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
// <auto-generated>
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for
// license information.
//
// Code generated by Microsoft (R) AutoRest Code Generator.
// Changes may cause incorrect behavior and will be lost if the code is
// regenerated.
// </auto-generated>

namespace Microsoft.Azure.Management.RecoveryServices.Backup
{
using Microsoft.Azure;
using Microsoft.Azure.Management;
using Microsoft.Azure.Management.RecoveryServices;
using Microsoft.Rest;
using Microsoft.Rest.Azure;
using Models;
Expand Down
7 changes: 3 additions & 4 deletions ...yServices.Backup/Management.RecoveryServices.Backup/Generated/BackupPoliciesOperations.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
// <auto-generated>
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for
// license information.
//
// Code generated by Microsoft (R) AutoRest Code Generator.
// Changes may cause incorrect behavior and will be lost if the code is
// regenerated.
// </auto-generated>

namespace Microsoft.Azure.Management.RecoveryServices.Backup
{
using Microsoft.Azure;
using Microsoft.Azure.Management;
using Microsoft.Azure.Management.RecoveryServices;
using Microsoft.Rest;
using Microsoft.Rest.Azure;
using Microsoft.Rest.Azure.OData;
Expand Down Expand Up @@ -101,7 +100,7 @@ internal BackupPoliciesOperations(RecoveryServicesBackupClient client)
{
throw new ValidationException(ValidationRules.CannotBeNull, "this.Client.SubscriptionId");
}
string apiVersion = "2016-12-01";
string apiVersion = "2017-07-01";
// Tracing
bool _shouldTrace = ServiceClientTracing.IsEnabled;
string _invocationId = null;
Expand Down
7 changes: 3 additions & 4 deletions ...Backup/Management.RecoveryServices.Backup/Generated/BackupPoliciesOperationsExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
// <auto-generated>
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for
// license information.
//
// Code generated by Microsoft (R) AutoRest Code Generator.
// Changes may cause incorrect behavior and will be lost if the code is
// regenerated.
// </auto-generated>

namespace Microsoft.Azure.Management.RecoveryServices.Backup
{
using Microsoft.Azure;
using Microsoft.Azure.Management;
using Microsoft.Azure.Management.RecoveryServices;
using Microsoft.Rest;
using Microsoft.Rest.Azure;
using Microsoft.Rest.Azure.OData;
Expand Down Expand Up @@ -42,7 +41,7 @@ public static partial class BackupPoliciesOperationsExtensions
/// </param>
public static IPage<ProtectionPolicyResource> List(this IBackupPoliciesOperations operations, string vaultName, string resourceGroupName, ODataQuery<ProtectionPolicyQueryObject> odataQuery = default(ODataQuery<ProtectionPolicyQueryObject>))
{
return ((IBackupPoliciesOperations)operations).ListAsync(vaultName, resourceGroupName, odataQuery).GetAwaiter().GetResult();
return operations.ListAsync(vaultName, resourceGroupName, odataQuery).GetAwaiter().GetResult();
}

/// <summary>
Expand Down
5 changes: 2 additions & 3 deletions ...s.Backup/Management.RecoveryServices.Backup/Generated/BackupProtectableItemsOperations.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
// <auto-generated>
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for
// license information.
//
// Code generated by Microsoft (R) AutoRest Code Generator.
// Changes may cause incorrect behavior and will be lost if the code is
// regenerated.
// </auto-generated>

namespace Microsoft.Azure.Management.RecoveryServices.Backup
{
using Microsoft.Azure;
using Microsoft.Azure.Management;
using Microsoft.Azure.Management.RecoveryServices;
using Microsoft.Rest;
using Microsoft.Rest.Azure;
using Microsoft.Rest.Azure.OData;
Expand Down
7 changes: 3 additions & 4 deletions ...anagement.RecoveryServices.Backup/Generated/BackupProtectableItemsOperationsExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
// <auto-generated>
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for
// license information.
//
// Code generated by Microsoft (R) AutoRest Code Generator.
// Changes may cause incorrect behavior and will be lost if the code is
// regenerated.
// </auto-generated>

namespace Microsoft.Azure.Management.RecoveryServices.Backup
{
using Microsoft.Azure;
using Microsoft.Azure.Management;
using Microsoft.Azure.Management.RecoveryServices;
using Microsoft.Rest;
using Microsoft.Rest.Azure;
using Microsoft.Rest.Azure.OData;
Expand Down Expand Up @@ -45,7 +44,7 @@ public static partial class BackupProtectableItemsOperationsExtensions
/// </param>
public static IPage<WorkloadProtectableItemResource> List(this IBackupProtectableItemsOperations operations, string vaultName, string resourceGroupName, ODataQuery<BMSPOQueryObject> odataQuery = default(ODataQuery<BMSPOQueryObject>), string skipToken = default(string))
{
return ((IBackupProtectableItemsOperations)operations).ListAsync(vaultName, resourceGroupName, odataQuery, skipToken).GetAwaiter().GetResult();
return operations.ListAsync(vaultName, resourceGroupName, odataQuery, skipToken).GetAwaiter().GetResult();
}

/// <summary>
Expand Down
7 changes: 3 additions & 4 deletions ...ces.Backup/Management.RecoveryServices.Backup/Generated/BackupProtectedItemsOperations.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
// <auto-generated>
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for
// license information.
//
// Code generated by Microsoft (R) AutoRest Code Generator.
// Changes may cause incorrect behavior and will be lost if the code is
// regenerated.
// </auto-generated>

namespace Microsoft.Azure.Management.RecoveryServices.Backup
{
using Microsoft.Azure;
using Microsoft.Azure.Management;
using Microsoft.Azure.Management.RecoveryServices;
using Microsoft.Rest;
using Microsoft.Rest.Azure;
using Microsoft.Rest.Azure.OData;
Expand Down Expand Up @@ -103,7 +102,7 @@ internal BackupProtectedItemsOperations(RecoveryServicesBackupClient client)
{
throw new ValidationException(ValidationRules.CannotBeNull, "this.Client.SubscriptionId");
}
string apiVersion = "2016-12-01";
string apiVersion = "2017-07-01";
Copy link
Copy Markdown
Contributor

@dsgouda dsgouda Jun 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frustoo2004
Looks like an SDK for the 2016-12-01 version was never published. Which implies the next SDK to be published will be a new version of the REST API, hence major version bump

Copy link
Copy Markdown
Author

@ghost ghost Jun 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsgouda , We have alerady published SDK with the following versions- "2016-12-01" and "2017-07-01". If I remember correctly, the last SDK publish date was August 2017. Let me know if you need any more information

Copy link
Copy Markdown
Author

@ghost ghost Jun 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding @DheerendraRathor , who published the last SDK.

Copy link
Copy Markdown
Contributor

@dsgouda dsgouda Jun 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version corresponds to the REST API version, not the SDK version.,

Copy link
Copy Markdown
Contributor

@DheerendraRathor DheerendraRathor Jun 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsgouda I don't get it. SDK was published with version 2016-12-01 in https://www.nuget.org/packages/Microsoft.Azure.Management.RecoveryServices.Backup/2.1.0-preview

Also why major version bump is required when only API version is upgraded and no contract change has been made given that api versions are not even transparent to SDK user?

Copy link
Copy Markdown
Contributor

@dsgouda dsgouda Jun 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frustoo2004 Could you point us to the nuget package that was published with 2017-07-01 API version?
@DheerendraRathor the concern is whenever we bump the API version (2016-12-01 to 2017-07-01 in this case) the major version number must be bumped for the package.
Hope this makes sense.

Copy link
Copy Markdown
Contributor

@DheerendraRathor DheerendraRathor Jun 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsgouda This doesn't make sense to me. Why does API version change require major version bumping when everything is backward compatible? And in case of C# SDK, user can't even change api-version so SDK is pretty much a black box here.
Last time major version bumping (from 1.3 to 2.0) was done due to real breaking changes!

Copy link
Copy Markdown
Author

@ghost ghost Jul 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shahabhijeet , Can you please review this?. @dsgouda , Can you please expedite the process?

Copy link
Copy Markdown
Contributor

@shahabhijeet shahabhijeet Jul 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frustoo2004 and @DheerendraRathor please understand that there are versioning requirements that .NET SDK follows.
You have couple of issues in this PR

  1. Why are you still in preview when your REST spec isn't
  2. Why have you bumped up your API version to begin with?
  • If you have not broken any contact, why the same changes cannot be applied to 2016-12-02

  1. SDK is just a reflection of your REST spec.

  2. Ideally you should be making additive change to your existing API version and not upgrade from 2016-12-01 to 2017-07-01

Since you last released, new feature has been introduced that the user will see the underlying API version on the nuget.org site (here is one such example)

For full desktop .NET framework scenarios, slso consider how can a user who wants to use functionality introduced in 2016 API version and 2017 SxS (side by side)

Please bump up major version if not, please clarify why have you changed the underlying API version if the changes are additive and does not break contracts or is it that this new functionality will not be applied in all regions?

Copy link
Copy Markdown
Contributor

@dsgouda dsgouda Jul 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frustoo2004 @DheerendraRathor please address @shahabhijeet 's comments here. Is there a reason why the REST spec is in stable version but the Nuget package is preview?

// Tracing
bool _shouldTrace = ServiceClientTracing.IsEnabled;
string _invocationId = null;
Expand Down
7 changes: 3 additions & 4 deletions .../Management.RecoveryServices.Backup/Generated/BackupProtectedItemsOperationsExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
// <auto-generated>
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for
// license information.
//
// Code generated by Microsoft (R) AutoRest Code Generator.
// Changes may cause incorrect behavior and will be lost if the code is
// regenerated.
// </auto-generated>

namespace Microsoft.Azure.Management.RecoveryServices.Backup
{
using Microsoft.Azure;
using Microsoft.Azure.Management;
using Microsoft.Azure.Management.RecoveryServices;
using Microsoft.Rest;
using Microsoft.Rest.Azure;
using Microsoft.Rest.Azure.OData;
Expand Down Expand Up @@ -44,7 +43,7 @@ public static partial class BackupProtectedItemsOperationsExtensions
/// </param>
public static IPage<ProtectedItemResource> List(this IBackupProtectedItemsOperations operations, string vaultName, string resourceGroupName, ODataQuery<ProtectedItemQueryObject> odataQuery = default(ODataQuery<ProtectedItemQueryObject>), string skipToken = default(string))
{
return ((IBackupProtectedItemsOperations)operations).ListAsync(vaultName, resourceGroupName, odataQuery, skipToken).GetAwaiter().GetResult();
return operations.ListAsync(vaultName, resourceGroupName, odataQuery, skipToken).GetAwaiter().GetResult();
}

/// <summary>
Expand Down
5 changes: 2 additions & 3 deletions ...ckup/Management.RecoveryServices.Backup/Generated/BackupProtectionContainersOperations.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
// <auto-generated>
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for
// license information.
//
// Code generated by Microsoft (R) AutoRest Code Generator.
// Changes may cause incorrect behavior and will be lost if the code is
// regenerated.
// </auto-generated>

namespace Microsoft.Azure.Management.RecoveryServices.Backup
{
using Microsoft.Azure;
using Microsoft.Azure.Management;
using Microsoft.Azure.Management.RecoveryServices;
using Microsoft.Rest;
using Microsoft.Rest.Azure;
using Microsoft.Rest.Azure.OData;
Expand Down
7 changes: 3 additions & 4 deletions ...ement.RecoveryServices.Backup/Generated/BackupProtectionContainersOperationsExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
// <auto-generated>
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for
// license information.
//
// Code generated by Microsoft (R) AutoRest Code Generator.
// Changes may cause incorrect behavior and will be lost if the code is
// regenerated.
// </auto-generated>

namespace Microsoft.Azure.Management.RecoveryServices.Backup
{
using Microsoft.Azure;
using Microsoft.Azure.Management;
using Microsoft.Azure.Management.RecoveryServices;
using Microsoft.Rest;
using Microsoft.Rest.Azure;
using Microsoft.Rest.Azure.OData;
Expand Down Expand Up @@ -41,7 +40,7 @@ public static partial class BackupProtectionContainersOperationsExtensions
/// </param>
public static IPage<ProtectionContainerResource> List(this IBackupProtectionContainersOperations operations, string vaultName, string resourceGroupName, ODataQuery<BMSContainerQueryObject> odataQuery = default(ODataQuery<BMSContainerQueryObject>))
{
return ((IBackupProtectionContainersOperations)operations).ListAsync(vaultName, resourceGroupName, odataQuery).GetAwaiter().GetResult();
return operations.ListAsync(vaultName, resourceGroupName, odataQuery).GetAwaiter().GetResult();
}

/// <summary>
Expand Down
Loading