Skip to content

Conversation

@hvermis
Copy link
Contributor

@hvermis hvermis commented Jun 22, 2018

Description


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@hvermis
Copy link
Contributor Author

hvermis commented Jun 22, 2018

Will add the release notes and updates to proj file in a separate commit.

@dsgouda
Copy link
Contributor

dsgouda commented Jun 22, 2018

@hvermis Please link the related REST spec

@hvermis
Copy link
Contributor Author

hvermis commented Jun 22, 2018

PR for swagger changes - Azure/azure-rest-api-specs#3270

@dsgouda dsgouda closed this Jun 25, 2018
@dsgouda dsgouda reopened this Jun 25, 2018
@dsgouda
Copy link
Contributor

dsgouda commented Jun 25, 2018

@azuresdkci Test this please

@dsgouda
Copy link
Contributor

dsgouda commented Jun 25, 2018

@hvermis Please fix the failing tests

<Version>1.0.0</Version>
<AssemblyName>Microsoft.Azure.Management.DataFactory</AssemblyName>
<PackageTags>Microsoft Azure resource management;Data Factory;ADF;</PackageTags>
<PackageReleaseNotes>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PackageReleaseNotes here

<PackageId>Microsoft.Azure.Management.DataFactory</PackageId>
<Description>Azure Data Factory V2 is the data integration platform that goes beyond Azure Data Factory V1's orchestration and batch-processing of time-series data, with a general purpose app model supporting modern data warehousing patterns and scenarios, lift-and-shift SSIS, and data-driven SaaS applications. Compose and manage reliable and secure data integration workflows at scale. Use native ADF data connectors and Integration Runtimes to move and transform cloud and on-premises data that can be unstructured, semi-structured, and structured with Hadoop, Azure Data Lake, Spark, SQL Server, Cosmos DB and many other data platforms.</Description>
<Version>0.8.0-preview</Version>
<Version>1.0.0</Version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the AssemblyInfo.cs too

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Please merge the commits into a single commit and this is good to merge

@hvermis hvermis merged commit 6f8124e into Azure:NetSdkADFV2 Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants