Skip to content

Fix the Add Api to Product and Fix Error model in OperationResultContract#4477

Merged
dsgouda merged 2 commits intoAzure:psSdkJson6from
solankisamir:psSdkJson6
Jun 25, 2018
Merged

Fix the Add Api to Product and Fix Error model in OperationResultContract#4477
dsgouda merged 2 commits intoAzure:psSdkJson6from
solankisamir:psSdkJson6

Conversation

@solankisamir
Copy link
Member

@solankisamir solankisamir commented Jun 21, 2018

Description

This is changes for bug fixes in Spec.
Issue: Azure/azure-rest-api-specs#3260
Swagger Spec changes:
Azure/azure-rest-api-specs#3258
Azure/azure-rest-api-specs#3272


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a generate.ps1 similar to this and regenerate the code.
Also, delete the generate.cmd file

<AssemblyTitle>Microsoft Azure API Management Management</AssemblyTitle>
<AssemblyName>Microsoft.Azure.Management.ApiManagement</AssemblyName>
<Version>4.0.2-preview</Version>
<Version>4.0.3-preview</Version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the AssmeblyFileVersion to 4.0.3 here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@solankisamir
Copy link
Member Author

@dsgouda can you take a look?

1 similar comment
@solankisamir
Copy link
Member Author

@dsgouda can you take a look?

Loading AutoRest core 'C:\Users\Sasolank\.autorest\@microsoft.azure_autorest-core@2.0.4280\node_modules\@microsoft.azure\autorest-core\dist' (2.0.4280)
Loading AutoRest extension '@microsoft.azure/autorest.csharp' (~2.2.51->2.2.57)
Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.43->2.3.43)
WARNING: "HEAD 'GetEntityTag' method missing 404 status code section -- this might be unintentional.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fearthecowboy any reason why AutoRest is emitting these warnings?
@shahabhijeet FYI

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit cb64362 into Azure:psSdkJson6 Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants