Merged
Conversation
Contributor
ralph-msft
commented
Jun 21, 2024
ralph-msft
commented
- Fixes some issues with the FineTuningClient and FileClient that were preventing fine tuning scenarios from working
- Wrong paths were being used in the generated REST requests
- Multi-part uploads were not setting the required Content-Type header correctly for each the file part
- File uploads for fine tuning return HTTP 201 which was treated as an error before
- Adds more thorough fine tuning model tests, as well as all the required types and clients to be able exercise all parts of the fine tuning model scenario
added 12 commits
June 7, 2024 13:58
- Fixes JSON issues due to moving to older JSON version - Fixes vector store test that was subject to race condition in status
…and cleanup - Fixed a bug where the path being used for jobs requests was incorrect (missing /jobs/) - Fixed abug where the job checkpoints was not generating correct requests - Added some internal only extension methods for FineTuningClient that allow you to delete a job in Azure OpenAI. This differs from how OpenAI works and this seemed liked the easiest way for now allowing testing and a suggestion for a future implementation - Added some test only models to make working with fine tuning clients easier - Added more thorough fine tuning testing including some very long running ones
NOTE: This only fixes the issue for Azure OpenAI. A proper fix will require updates to the autogenerated code which will in a later PR
ralph-msft
requested review from
joseharriaga,
jpalvarezl,
m-nash and
trrwilson
as code owners
Collaborator
|
API change check API changes are not detected in this pull request. |
trrwilson
reviewed
Jun 21, 2024
trrwilson
reviewed
Jun 21, 2024
trrwilson
reviewed
Jun 21, 2024
sdk/openai/Azure.AI.OpenAI/src/Custom/FineTuning/AzureFineTuningClient.Extensions.cs
Outdated
Show resolved
Hide resolved
trrwilson
reviewed
Jun 21, 2024
sdk/openai/Azure.AI.OpenAI/src/Custom/FineTuning/AzureFineTuningClient.Extensions.cs
Outdated
Show resolved
Hide resolved
trrwilson
reviewed
Jun 21, 2024
sdk/openai/Azure.AI.OpenAI/src/Custom/FineTuning/AzureFineTuningClient.Extensions.cs
Outdated
Show resolved
Hide resolved
trrwilson
reviewed
Jun 21, 2024
trrwilson
approved these changes
Jun 24, 2024
tejasm-microsoft
pushed a commit
to tejasm-microsoft/azure-sdk-for-net
that referenced
this pull request
Jul 22, 2024
- Fixes some issues with the FineTuningClient and FileClient that were preventing fine tuning scenarios from working - Wrong paths were being used in the generated REST requests - Multi-part uploads were not setting the required Content-Type header correctly for each the file part - File uploads for fine tuning return HTTP 201 which was treated as an error before - Adds more thorough fine tuning model tests, as well as all the required types and clients to be able exercise all parts of the fine tuning model scenario
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.