Skip to content

Conversation

@meiyan-Li
Copy link
Contributor

@meiyan-Li meiyan-Li commented Jun 19, 2018

Description

This change is removing maxParallelExecutionsPerNode limitation in SDK, there is no manually code change, all the code change are generated with spec change in this PR
Azure/azure-rest-api-specs#3237

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@meiyan-Li meiyan-Li changed the title Remove maximum maxParallelExecutionsPerNode validation [Datafactory] Remove maximum maxParallelExecutionsPerNode validation Jun 19, 2018
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.8.0-preview package is already published, please update the package version in csproj

@meiyan-Li
Copy link
Contributor Author

meiyan-Li commented Jun 20, 2018

@hvermis @dsgouda I updated sdk version to 0.9.0-preview, please take a look. When will this version be published?

@hvermis
Copy link
Contributor

hvermis commented Jun 20, 2018

@meiyan-Li We don't have the publish date yet, I will sync with you offline.

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 4314971 into Azure:psSdkJson6 Jun 20, 2018
@dsgouda
Copy link
Contributor

dsgouda commented Jun 20, 2018

@meiyan-Li you can kick off a publish job yourself when you are ready, please sync up with @hvermis prior to it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants