Skip to content

ClientModel prototype: LRO abstractions using the "struct" approach#44276

Closed
annelo-msft wants to merge 14 commits intoAzure:mainfrom
annelo-msft:clientmodel-lro-exp2
Closed

ClientModel prototype: LRO abstractions using the "struct" approach#44276
annelo-msft wants to merge 14 commits intoAzure:mainfrom
annelo-msft:clientmodel-lro-exp2

Conversation

@annelo-msft
Copy link
Copy Markdown
Contributor

@annelo-msft annelo-msft commented May 28, 2024

This approach explores adding a third LRO type representing the tuple of status and value for a progressively-resolved result of a service LRO.

Note its similarity to Page in the pageable abstraction set.

This adds a lot of implementation complexity, and makes you implement polling in something that's essentially a model type. Doesn't seem better than #44275

I guess the question is - is there value in having a separate type like page that holds the individual response and some additional meta-data about the operation that's at a lower-level of abstraction. That fact that you access it through Operation.Value seems kludgy and awkward, though. If we let you access it through a different method like "AsPages" might hide the complexity, but I think would also require you to either pass the status type parameter (I wouldn't expect this to be discoverable), or somehow specify the type parameter in the top-level type, which we're trying to avoid.

@azure-sdk
Copy link
Copy Markdown
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

System.ClientModel

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 2, 2024

Hi @annelo-msft. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions Bot added the no-recent-activity There has been no recent activity on this issue. label Aug 2, 2024
@annelo-msft annelo-msft closed this Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure.Core no-recent-activity There has been no recent activity on this issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants