-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Fix AOT warnings for LRO rehydration #44208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
API change check API changes are not detected in this pull request. |
sdk/core/Azure.Core/src/Shared/NextLinkOperationImplementation.cs
Outdated
Show resolved
Hide resolved
sdk/core/Azure.Core/src/Shared/NextLinkOperationImplementation.cs
Outdated
Show resolved
Hide resolved
jsquire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we don't want to reconsider making members public at present and AOT issues are resolved by JsonDocument.Parse.
m-redding
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - the remaining BinaryData warnings are coming from System.Memory.Data - not this file
Would it make sense to look for an approach that doesn't require using the BinaryData APIs that trigger the warning? |
The BinaryData APIs that don't trigger warnings take a |
Resolves #44127
https://github.com/dotnet/runtime/blob/3b95ae9494c6d1580b2ccbf06db7b04af1a265b1/src/libraries/System.Memory.Data/src/System/BinaryData.cs#L88-L92
to
https://github.com/dotnet/runtime/blob/3b95ae9494c6d1580b2ccbf06db7b04af1a265b1/src/libraries/System.Memory.Data/src/System/BinaryData.cs#L140
https://github.com/dotnet/runtime/blob/3b95ae9494c6d1580b2ccbf06db7b04af1a265b1/src/libraries/System.Memory.Data/src/System/BinaryData.cs#L424-L427
to
https://github.com/dotnet/runtime/blob/a17b872de7639a8b3182390b9ac54cb913b62bd1/src/libraries/System.Text.Json/src/System/Text/Json/Document/JsonDocument.Parse.cs#L47
The AOT warnings now running from https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/tests/Azure.Monitor.OpenTelemetry.Exporter.AotCompatibilityTestApp/test-aot-compat.ps1 are