Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET SDK for Oracle.Database #44106

Conversation

v-jamcheung
Copy link
Member

@v-jamcheung v-jamcheung commented May 17, 2024

.NET SDK for Oracle.Database

Library Namespace: Azure.ResourceManager.OracleDatabase (Azure/azure-sdk#7507)
Merged PR for Oracle.Database Stable Spec: Azure/azure-rest-api-specs#28090

Copy link

Thank you for your contribution @v-jamcheung! We will review the pull request and get back to you soon.

@github-actions github-actions bot added customer-reported Issues that are reported by GitHub users external to the Azure organization. Mgmt This issue is related to a management-plane library. labels May 17, 2024
Copy link
Member

@jsquire jsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@v-jamcheung:

Your account lacks the required public GitHub organizations and permissions required of an internal contributor. Please review the Azure SDK onboarding documentation and use the associated Teams channel for support.

You can verify the state of your account by running the Validate-AzsdkCodeOwner script from the Azure SDK tools repository.

Please also be sure to add yourself to CODEOWNERS for this library, if you will be maintaining it going forward.

.github/CODEOWNERS Outdated Show resolved Hide resolved
@v-jamcheung
Copy link
Member Author

@v-jamcheung:

Your account lacks the required public GitHub organizations and permissions required of an internal contributor. Please review the Azure SDK onboarding documentation and use the associated Teams channel for support.

You can verify the state of your account by running the Validate-AzsdkCodeOwner script from the Azure SDK tools repository.

Please also be sure to add yourself to CODEOWNERS for this library, if you will be maintaining it going forward.

Updated CODEOWNERS.

As for the permissions, I believe I will not need write permissions as someone else will be assigned this PR and will merge it once I have addressed all the comments and gotten the necessary approvals.

@jsquire
Copy link
Member

jsquire commented May 22, 2024

@v-jamcheung:
Your account lacks the required public GitHub organizations and permissions required of an internal contributor. Please review the Azure SDK onboarding documentation and use the associated Teams channel for support.

You can verify the state of your account by running the Validate-AzsdkCodeOwner script from the Azure SDK tools repository.
Please also be sure to add yourself to CODEOWNERS for this library, if you will be maintaining it going forward.

Updated CODEOWNERS.

As for the permissions, I believe I will not need write permissions as someone else will be assigned this PR and will merge it once I have addressed all the comments and gotten the necessary approvals.

You cannot appear in CODEOWNERS without the proper memberships and rights. Whether you complete this PR or no, you'll need to request permissions.

@v-jamcheung
Copy link
Member Author

@ArthurMa1978 @KrzysztofCwalina @tg-msft @archerzz @ArcturusZhang @pallavit @ronniegeraghty

Hi team,

I am currently writing the tests for this .NET SDK.
Meanwhile please could people review the SDK code and leave comments if there are any issues.

Thanks.

@ronniegeraghty
Copy link
Member

ronniegeraghty commented May 23, 2024

Checking a couple of things here.
If @v-jamcheung is an internal contributor, I'll remove the Community Contribution and customer-reported labels.

@v-jamcheung, can you tell me how the list of reviewers was added to this PR?
Looking at our CODEOWNERS there is no specific listing for /sdk/oracle/* so it should have reverted to the owners for /sdk/ which are @jsquire and @pallavit. Did you manually add the other reviewers listed?

@jsquire is there an existing service label for this library or do we need a new one?

@ronniegeraghty ronniegeraghty removed customer-reported Issues that are reported by GitHub users external to the Azure organization. Community Contribution Community members are working on the issue labels May 23, 2024
@jsquire
Copy link
Member

jsquire commented May 23, 2024

@ronniegeraghty: It's a management library, which correctly routes to Arthur and team when there are no CODEOWNERS.

Copy link
Member

@archerzz archerzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@v-jamcheung could you please fix the errors in the CI pipeline? Thanks.

@v-jamcheung
Copy link
Member Author

New PR containing regenerated SDK code after typespec PR (Azure/azure-rest-api-specs#29305) was merged: #44499

Putting playback testing on hold, will add them before releasing stable version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants