-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.NET SDK for Oracle.Database #44106
.NET SDK for Oracle.Database #44106
Conversation
Thank you for your contribution @v-jamcheung! We will review the pull request and get back to you soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your account lacks the required public GitHub organizations and permissions required of an internal contributor. Please review the Azure SDK onboarding documentation and use the associated Teams channel for support.
- Azure SDK onboarding (Microsoft internal)
- Azure SDK onboarding assistance (Microsoft internal)
You can verify the state of your account by running the Validate-AzsdkCodeOwner script from the Azure SDK tools repository.
Please also be sure to add yourself to CODEOWNERS for this library, if you will be maintaining it going forward.
… into v-jamcheung/net-sdk-for-oracle-database
Updated CODEOWNERS. As for the permissions, I believe I will not need write permissions as someone else will be assigned this PR and will merge it once I have addressed all the comments and gotten the necessary approvals. |
You cannot appear in CODEOWNERS without the proper memberships and rights. Whether you complete this PR or no, you'll need to request permissions. |
@ArthurMa1978 @KrzysztofCwalina @tg-msft @archerzz @ArcturusZhang @pallavit @ronniegeraghty Hi team, I am currently writing the tests for this .NET SDK. Thanks. |
Checking a couple of things here. @v-jamcheung, can you tell me how the list of reviewers was added to this PR? @jsquire is there an existing service label for this library or do we need a new one? |
@ronniegeraghty: It's a management library, which correctly routes to Arthur and team when there are no CODEOWNERS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@v-jamcheung could you please fix the errors in the CI pipeline? Thanks.
New PR containing regenerated SDK code after typespec PR (Azure/azure-rest-api-specs#29305) was merged: #44499 Putting playback testing on hold, will add them before releasing stable version. |
.NET SDK for Oracle.Database
Library Namespace: Azure.ResourceManager.OracleDatabase (Azure/azure-sdk#7507)
Merged PR for Oracle.Database Stable Spec: Azure/azure-rest-api-specs#28090