Skip to content

[Compute] Add IP tag for VMSS and fix the name of list vm extension API.#4405

Merged
shahabhijeet merged 1 commit intoAzure:psSdkJson6from
hyonholee:june
Jun 5, 2018
Merged

[Compute] Add IP tag for VMSS and fix the name of list vm extension API.#4405
shahabhijeet merged 1 commit intoAzure:psSdkJson6from
hyonholee:june

Conversation

@hyonholee
Copy link
Copy Markdown
Contributor

@hyonholee hyonholee commented Jun 3, 2018

Azure/azure-rest-api-specs#3152

Description


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

Copy link
Copy Markdown
Contributor

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you link the spec PR?
Also build your sdk locally so it updates the metadata.

@hyonholee
Copy link
Copy Markdown
Contributor Author

@shahabhijeet I build the SDK locally, but nothing is updated after build.

Copy link
Copy Markdown
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM subject to CIs passing

@shahabhijeet
Copy link
Copy Markdown
Contributor

@azuresdkci retest this please

@shahabhijeet shahabhijeet reopened this Jun 5, 2018
@shahabhijeet shahabhijeet merged commit 65a1cf3 into Azure:psSdkJson6 Jun 5, 2018
@hyonholee hyonholee deleted the june branch June 30, 2018 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants