Skip to content

[ADLS] add vnet and tests#4401

Merged
shahabhijeet merged 5 commits into
Azure:psSdkJson6from
lewu-msft:psSdkJson6
Jun 12, 2018
Merged

[ADLS] add vnet and tests#4401
shahabhijeet merged 5 commits into
Azure:psSdkJson6from
lewu-msft:psSdkJson6

Conversation

@lewu-msft
Copy link
Copy Markdown
Contributor

@lewu-msft lewu-msft commented May 31, 2018

Description

Added virtual network CRUD operations for account management.
(Azure/azure-rest-api-specs@b66d57b)

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

dsgouda
dsgouda suggested changes Jun 1, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a generate.ps1 similar to this and regenerate the code. Please commit all the changes the script generates.
Also, run msbuild build.proj /t:Build /p:Scope=SDKs\DataLake.Store\Management/DataLake.Store and commit all artifacts generated

Comment thread ...Ks/DataLake.Store/Management.DataLake.Store/Microsoft.Azure.Management.DataLake.Store.csproj Outdated
@@ -6,7 +6,7 @@
<PropertyGroup>
<PackageId>Microsoft.Azure.Management.DataLake.Store</PackageId>
<Description>Provides Data Lake Store account and filesystem management capabilities for Microsoft Azure.</Description>
<Version>2.4.0-preview</Version>
<Version>2.5.0-preview</Version>
Copy link
Copy Markdown
Contributor

@dsgouda dsgouda Jun 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lewu-msft Looks like you are only making additive changes here, theoretically you could release 2.4.1-preview version, however I leave it your discretion

@dsgouda
Copy link
Copy Markdown
Contributor

dsgouda commented Jun 1, 2018

@lewu-msft Please fix failing tests

@dsgouda
Copy link
Copy Markdown
Contributor

dsgouda commented Jun 5, 2018

@lewu-msft gentle ping.

@dsgouda
Copy link
Copy Markdown
Contributor

dsgouda commented Jun 7, 2018

@lewu-msft tests are still failing

@lewu-msft
Copy link
Copy Markdown
Contributor Author

lewu-msft commented Jun 7, 2018 •
edited
Loading

@dsgouda working on it. tests passed locally but fail after pushing to repo

shahabhijeet
shahabhijeet suggested changes Jun 11, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are introducing breaking changes, you will need to bump up the major version of your package.
Left minor comments that needs to be addressed

Comment thread src/SDKs/DataLake.Store/Management.DataLake.Store/generate.ps1 Outdated
@@ -0,0 +1 @@
powershell.exe -ExecutionPolicy Bypass -NoLogo -NonInteractive -NoProfile -File "$(split-path $SCRIPT:MyInvocation.MyCommand.Path -parent)\..\..\..\..\tools\generateTool.ps1" -ResourceProvider "datalake-store/resource-manager" -PowershellInvoker -AutoRestVersion "latest" No newline at end of file
Copy link
Copy Markdown
Contributor

@shahabhijeet shahabhijeet Jun 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lewu-msft please model the generate.ps1 according to what you see over here
https://github.com/Azure/azure-sdk-for-net/blob/psSdkJson6/src/SDKs/Compute/Management.Compute/generate.ps1#L1

Copy link
Copy Markdown
Contributor Author

@lewu-msft lewu-msft Jun 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shahabhijeet Thx! updated

Comment thread ...Ks/DataLake.Store/Management.DataLake.Store/Microsoft.Azure.Management.DataLake.Store.csproj
<PackageId>Microsoft.Azure.Management.DataLake.Store</PackageId>
<Description>Provides Data Lake Store account and filesystem management capabilities for Microsoft Azure.</Description>
<Version>2.4.0-preview</Version>
<Version>2.4.1-preview</Version>
Copy link
Copy Markdown
Contributor

@shahabhijeet shahabhijeet Jun 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lewu-msft please update package release notes.

@shahabhijeet shahabhijeet merged commit fd946b6 into Azure:psSdkJson6 Jun 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@dsgouda dsgouda dsgouda requested changes

@shahabhijeet shahabhijeet shahabhijeet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@shahabhijeet shahabhijeet

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lewu-msft @dsgouda @shahabhijeet