Add tests to ComputerVision for full coverage#4388
Closed
cthrash wants to merge 6 commits intoAzure:psSdkJson6from
Closed
Add tests to ComputerVision for full coverage#4388cthrash wants to merge 6 commits intoAzure:psSdkJson6from
cthrash wants to merge 6 commits intoAzure:psSdkJson6from
Conversation
The HttpRecorder did not correctly play back binary content. The propsed fix is to introduce new fields in `RecordEntry` named `IsRequestBodyBinary`/`IsResponseBodyBinary`, and use base64 encoding/decoding when the payload is deemed to be binary. Currently the test for binary-ness is a simple MIME type regex match. Note that this PR includes tests to confirm the new behavior. It will failed to build without hacking around the fact that the test code depends on the NuGet-installed Microsoft.Azure.Test.HttpRecorder.dll. If it is preferable to split the PR so you can update NuGet first without the tests failing, please let me know.
Test images for forthcoming tests. Checking in first so they can be reference via URL via githubusercontent.
Generated from [PR](Azure/azure-rest-api-specs#3145).
Tests covering all the API methods.
Go back to the old HttpRecorder for now. Thumbnail tests are commented out until it is fixed.
Contributor
Author
|
meant to exclude httprecorder changes, let me redo this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The checked in REST spec had a number of problem which were fixed. Tests now cover these cases.
Swagger PR.
Please see related PR regarding HttpRecorder.
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.