ClientModel: Add SSE result collection#43821
Closed
annelo-msft wants to merge 16 commits intoAzure:mainfrom
Closed
ClientModel: Add SSE result collection#43821annelo-msft wants to merge 16 commits intoAzure:mainfrom
annelo-msft wants to merge 16 commits intoAzure:mainfrom
Conversation
…be replaced in a polling paradigm
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
annelo-msft
commented
May 3, 2024
| /// <param name="response">The <see cref="PipelineResponse"/> received | ||
| /// from the service.</param> | ||
| protected ClientResult(PipelineResponse response) | ||
| protected ClientResult(PipelineResponse? response) |
Contributor
Author
There was a problem hiding this comment.
We would only include this change if we have good reason to believe we'll want it for pageable/operation types in the future.
annelo-msft
commented
May 3, 2024
| public abstract IAsyncEnumerator<T> GetAsyncEnumerator(CancellationToken cancellationToken = default); | ||
|
|
||
| // TODO: take CancellationToken? | ||
| //public static ClientResultCollection<T> Create<TValue>(PipelineResponse response) where TValue : IJsonModel<T> |
Contributor
Author
There was a problem hiding this comment.
TODO: could we accomplish this method signature?
annelo-msft
commented
May 3, 2024
|
|
||
| public abstract IAsyncEnumerator<T> GetAsyncEnumerator(CancellationToken cancellationToken = default); | ||
|
|
||
| // TODO: take CancellationToken? |
Contributor
Author
There was a problem hiding this comment.
TODO: Take cancellation token in factory method?
annelo-msft
commented
May 3, 2024
| /// to the response most recently returned from the service.</remarks> | ||
| /// <param name="response">The <see cref="PipelineResponse"/> to return | ||
| /// from <see cref="GetRawResponse"/>.</param> | ||
| protected void SetRawResponse(PipelineResponse response) |
Contributor
Author
There was a problem hiding this comment.
TODO: Assert not null per nullability annotation
annelo-msft
commented
May 3, 2024
|
|
||
| namespace System.ClientModel; | ||
|
|
||
| // TODO: Re-enable sync version |
Contributor
Author
There was a problem hiding this comment.
TODO: sync result collection
annelo-msft
commented
May 3, 2024
|
|
||
| internal sealed class AsyncServerSentEventEnumerator : IAsyncEnumerator<ServerSentEvent>, IDisposable, IAsyncDisposable | ||
| { | ||
| // TODO: make this configurable per coming from TypeSpec |
Contributor
Author
There was a problem hiding this comment.
TODO: parameterize terminal event
annelo-msft
commented
May 3, 2024
annelo-msft
commented
May 3, 2024
| return new(response, GetServerSentEventDeserializationEnumerator<U>); | ||
| } | ||
|
|
||
| private static IAsyncEnumerator<U> GetServerSentEventDeserializationEnumerator<U>(Stream stream, CancellationToken cancellationToken = default) |
Contributor
Author
There was a problem hiding this comment.
Curious: Why a func?
annelo-msft
commented
May 3, 2024
|
|
||
| #region Helpers | ||
|
|
||
| private string _mockContent = """ |
Contributor
Author
There was a problem hiding this comment.
TODO: put it in one place? Currently copied a lot.
Also: more robust set of test cases?
Contributor
Author
|
Closing in favor of #43840 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.