Skip to content

Prototype of JsonModel<T> abstract class#43571

Closed
annelo-msft wants to merge 5 commits intoAzure:mainfrom
annelo-msft:clientmodel-jsonmodel-proto1
Closed

Prototype of JsonModel<T> abstract class#43571
annelo-msft wants to merge 5 commits intoAzure:mainfrom
annelo-msft:clientmodel-jsonmodel-proto1

Conversation

@annelo-msft
Copy link
Copy Markdown
Contributor

No description provided.

}
public partial interface IJsonModel
{
System.Collections.Generic.IDictionary<string, object> AdditionalProperties { get; }
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be appropriate that we call it AdditionalProperties?
A generated model in our current generated libraries might have AdditionalProperties property if this is defined in the spec, and its type is usually IDictionary<string, BinaryData> or IReadOnlyDictionary<string, BinaryData>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a good point, and this is currently an open question under discussion - whether we should merge this feature with the existing AdditionalProperties feature. It is currently unclear whether we would want multiple property dictionaries on a type -- it sounds like we would prefer a single dictionary that supported both/all three cases (with _serializedAdditionalRawData as well), but the details of how this would work have not been finalized.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 5, 2024

Hi @annelo-msft. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions Bot added the no-recent-activity There has been no recent activity on this issue. label Jul 5, 2024
@github-actions
Copy link
Copy Markdown

Hi @annelo-msft. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing /reopen if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure.Core no-recent-activity There has been no recent activity on this issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants