Update ManagementGroups SDK (2018-03-01-preview)#4349
Update ManagementGroups SDK (2018-03-01-preview)#4349dsgouda merged 3 commits intoAzure:psSdkJson6from rajshah11:mgmt-group-2018-03-01-sdk
Conversation
| [assembly: AssemblyVersion("1.1.0.0")] | ||
| [assembly: AssemblyFileVersion("1.1.0.0")] | ||
| [assembly: AssemblyVersion("1.2.0.0")] | ||
| [assembly: AssemblyFileVersion("1.2.0.0")] |
There was a problem hiding this comment.
Only update the AssemblyFileVersion here
There was a problem hiding this comment.
Okay. Thanks. Will make the change.
| <PackageId>Microsoft.Azure.Management.ManagementGroups</PackageId> | ||
| <PackageTags>Microsoft Azure Management Groups;Management Groups;Groups;</PackageTags> | ||
| <PackageReleaseNotes>This is a public preview release of the Azure Management Groups SDK</PackageReleaseNotes> | ||
| <PackageReleaseNotes>This is a general availibility release of the Azure Management Groups SDK</PackageReleaseNotes> |
There was a problem hiding this comment.
So, is this a stable release?
There was a problem hiding this comment.
Yes. We are GAing the end of this month.
There was a problem hiding this comment.
In that case, you will need to remove the -preview from the package version.
There was a problem hiding this comment.
Actually, if removing the preview tag is not a requirement for GAing a service we would like to keep it. Please let me know if we can keep the preview tag.
|
@rajshah11 if you received all the necessary information from @shahabhijeet I can approve this PR |
dsgouda
left a comment
There was a problem hiding this comment.
LGTM subject to CIs passing
Description
Rest API Spec PRs
Azure/azure-rest-api-specs#3064
Azure/azure-rest-api-specs#3115
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.