Generate Compute client library version 19.0.0 and update the tests.#4346
Merged
dsgouda merged 1 commit intoAzure:psSdkJson6from May 23, 2018
Merged
Generate Compute client library version 19.0.0 and update the tests.#4346dsgouda merged 1 commit intoAzure:psSdkJson6from
dsgouda merged 1 commit intoAzure:psSdkJson6from
Conversation
dsgouda
suggested changes
May 21, 2018
Contributor
dsgouda
left a comment
There was a problem hiding this comment.
Looks good for the most part
Contributor
There was a problem hiding this comment.
Please regenerate the code using generate.ps1 script here
Contributor
Author
|
@dsgouda I generated the code using the powershell script and updated the PR. |
dsgouda
approved these changes
May 22, 2018
Contributor
dsgouda
left a comment
There was a problem hiding this comment.
LGTM subject to CI builds passing
dsgouda
suggested changes
May 22, 2018
Contributor
dsgouda
left a comment
There was a problem hiding this comment.
Please fix failing tests
Contributor
Author
|
@dsgouda Fixed tests and all checks passed. |
This was referenced Jun 15, 2023
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.