Adding vulnerability Assessemtn clinet code #4327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@jaredmoo - please review too... |
jaredmoo
suggested changes
May 16, 2018
Contributor
jaredmoo
left a comment
jaredmoo
left a comment
There was a problem hiding this comment.
Overall looking pretty good :)
| /// Gets or sets the recurring scans settings | ||
| /// </summary> | ||
| [JsonProperty(PropertyName = "properties.recurringScans")] | ||
| public VulnerabilityAssessmentRecurringScansProperties RecurringScans { get; set; } |
Contributor
There was a problem hiding this comment.
Do you not want to flatten these properties up into this class? Either way is fine, but I want to check it is a conscious decision :)
Member
Author
There was a problem hiding this comment.
It is a conscious decision.
I'll flatten these properties up in powershell
| /// parameter. | ||
| /// </summary> | ||
| [JsonProperty(PropertyName = "properties.storageContainerSasKey")] | ||
| public string StorageContainerSasKey { get; set; } |
Contributor
There was a problem hiding this comment.
Are any of these properties required?
|
|
||
| sqlClient.DatabaseVulnerabilityAssessmentRuleBaselines.CreateOrUpdate(resourceGroup.Name, server.Name, dbName, testRuleId, ruleBaselineToSet); | ||
|
|
||
| // Get basleine |
Contributor
There was a problem hiding this comment.
Same typo is copied a few times elsewhere
| string scanId1 = string.Format("scantest2_{0}", DateTime.UtcNow.Ticks); | ||
| sqlClient.DatabaseVulnerabilityAssessmentScans.Execute(resourceGroup.Name, server.Name, dbName, scanId1); | ||
|
|
||
| // Veroify get scan and list scans |
| await SetPolicy(context, sqlClient, resourceGroup, server, dbName); | ||
|
|
||
| // Run some scans | ||
| string scanId = string.Format("scantest1_{0}", DateTime.UtcNow.Ticks); |
Contributor
There was a problem hiding this comment.
How is this going to work with test playback? UtcNow is different every time you run the test, so the scan uri is not reproducable
|
|
||
| // Run some scans | ||
| string scanId = string.Format("scantest1_{0}", DateTime.UtcNow.Ticks); | ||
| sqlClient.DatabaseVulnerabilityAssessmentScans.Execute(resourceGroup.Name, server.Name, dbName, scanId); |
Contributor
There was a problem hiding this comment.
Wasn't this changed to InitiateScan?
Member
Author
There was a problem hiding this comment.
yep, it was.
will change the client code and update the swagger in azure-rest-api-specs repo
Contributor
|
@yaakoviyun Please fix failing test cases |
dsgouda
suggested changes
May 17, 2018
Contributor
dsgouda
left a comment
dsgouda
left a comment
There was a problem hiding this comment.
These look like additive changes. Please bump the minor version in csproj file along with PackageReleaseNotes
9 tasks
AutorestCI
added a commit
to Azure/azure-sdk-for-python
that referenced
this pull request
May 21, 2018
Added needed changes to Swagger and exampels Added needed changes to Swagger Azure/azure-sdk-for-net#4327 (review)
AutorestCI
added a commit
to Azure/azure-sdk-for-go
that referenced
this pull request
May 21, 2018
Added needed changes to Swagger and exampels Added needed changes to Swagger Azure/azure-sdk-for-net#4327 (review)
AutorestCI
added a commit
to AutorestCI/azure-libraries-for-java
that referenced
this pull request
May 21, 2018
Added needed changes to Swagger and exampels Added needed changes to Swagger Azure/azure-sdk-for-net#4327 (review)
AutorestCI
added a commit
to Azure/azure-sdk-for-node
that referenced
this pull request
May 21, 2018
Added needed changes to Swagger and exampels Added needed changes to Swagger Azure/azure-sdk-for-net#4327 (review)
Turn ON database threat detection as a preprequite to use VA
Contributor
|
@dsgouda - Jenkins build failure below seems like not our fault |
jaredmoo
approved these changes
May 22, 2018
Member
Author
|
@dsgouda , can you merge? |
9 tasks
Contributor
|
This PR was merged into #4351 and can be closed, |
anuchandy
pushed a commit
to Azure/azure-rest-api-specs
that referenced
this pull request
May 23, 2018
* Adding Vulnerability Assessment APIs on managed instance Adding Vulnerability Assessment APIs on managed instance * fixed scan operation id * character mismatch fix * Added needed changes to Swagger and exampels Added needed changes to Swagger Azure/azure-sdk-for-net#4327 (review) * Delete managedDatabaseVulnerabilityAssessmentBaselines.json * Delete managedDatabaseVulnerabilityAssessmentScans.json * Delete managedDatabaseVulnerabilityAssessments.json * Delete ManagedDatabaseVulnerabilityAssessmentCreateMax.json * Delete ManagedDatabaseVulnerabilityAssessmentCreateMin.json * Delete ManagedDatabaseVulnerabilityAssessmentDelete.json * Delete ManagedDatabaseVulnerabilityAssessmentGet.json * Delete ManagedDatabaseVulnerabilityAssessmentRuleBaselineCreate.json * Delete ManagedDatabaseVulnerabilityAssessmentRuleBaselineDelete.json * Delete ManagedDatabaseVulnerabilityAssessmentRuleBaselineGet.json * Delete ManagedDatabaseVulnerabilityAssessmentScanExport.json * Delete ManagedDatabaseVulnerabilityAssessmentScanRecordsGet.json * Delete ManagedDatabaseVulnerabilityAssessmentScanRecordsListByDatabase.json * Delete ManagedDatabaseVulnerabilityAssessmentScansExecute.json * Update readme.md
AutorestCI
added a commit
to Azure/azure-sdk-for-go
that referenced
this pull request
Jun 17, 2018
Added needed changes to Swagger and exampels Added needed changes to Swagger Azure/azure-sdk-for-net#4327 (review)
AutorestCI
added a commit
to Azure/azure-sdk-for-node
that referenced
this pull request
Jun 17, 2018
Added needed changes to Swagger and exampels Added needed changes to Swagger Azure/azure-sdk-for-net#4327 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding vulnerability Assessemtn clinet code