Update AutoRest C# version to 3.0.0-beta.20240404.1#43204
Merged
AlexanderSher merged 11 commits intoAzure:mainfrom Apr 4, 2024
Merged
Update AutoRest C# version to 3.0.0-beta.20240404.1#43204AlexanderSher merged 11 commits intoAzure:mainfrom
AlexanderSher merged 11 commits intoAzure:mainfrom
Conversation
azure-sdk
requested review from
ArcturusZhang,
ArthurMa1978,
JoshLove-msft,
KrzysztofCwalina,
amnguye,
annelo-msft,
archerzz,
benbp,
christothes,
giakas,
hallipr,
jaschrep-msft,
jsquire,
m-nash,
pallavit,
rasidhan,
schaabs,
seanmcc-msft,
tg-msft,
weshaggard,
wonner and
yeskarthik
as code owners
azure-sdk
requested review from
a team,
AikoBB,
LuChen-Microsoft,
MikeyMCZ,
RoyHerrod,
ajpeacock0,
allchiang-msft,
danielav7,
gfeitosa-msft,
ilyapaliakou-msft,
joseharriaga,
maximrytych-ms,
miguhern,
mikehang-msft,
minnieliu,
minwoolee-msft,
mjafferi-msft,
nathpete-msft,
paolamvhz,
phermanov-msft,
quentinRobinson,
shwali-msft,
sjiherzig and
whisper6284
as code owners
heaths
reviewed
Apr 4, 2024
Member
heaths
left a comment
heaths
left a comment
There was a problem hiding this comment.
Why, at least for Key Vault, is a method being added that's not even called? Or is it a static interface implementation with a generic return parameter? Linking these somehow to a changelog or something in Azure/autorest.csharp would help.
Contributor
It will be called on the later phase of consolidation work. HLC Rest Clients will call these to serialize/deserialize models, similar to DPG |
AlexanderSher
approved these changes
Apr 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update AutoRest C# version to 3.0.0-beta.20240404.1