SDK changes for traffic analytics parameters added to existing networkwatcher flowlog parameters

[sayghosh]

Description

---

This checklist is used to make sure that common guidelines for a pull request are followed.

• Please add REST spec PR link to the SDK PR
• I have read the contribution guidelines.
• The pull request does not introduce breaking changes.

General Guidelines

• Title of the pull request is clear and informative.
• There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

• Pull request includes test coverage for the included changes.

SDK Generation Guidelines

• If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
• The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
• The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

[sayghosh]

Here is the REST spec PR link: Azure/azure-rest-api-specs#3023

[dsgouda]

@MikhailTryakhov is the official may release for network sdk repo? Please confirm

[MikhailTryakhov]

@dsgouda no it's not. The deadline of swagger is May, 17
@sayghosh you have to use minot version change 19.0.0.0->19.0.0.1 or something like that.
The official 20.0.0.0 one would be able later.

[sayghosh]

@MikhailTryakhov pushed it down to 19.0.1.0.

[MikhailTryakhov]

Thanks, LGTM
@dsgouda if you're still not sure we can sync up with Samer - this is my first experience with minor versions publishing :)
Let's help Sayantan with publishing this version soon - he worked really hard to do everything in time ;)

[sayghosh]

Build failure cause:

Is this an intermittent issue? If so, can we re trigger the build? For reference, here is a successful build for the Network module on the same fork with latest changes: https://azuresdkci.westus2.cloudapp.azure.com/job/NetCore-SDK-Sign/327/

[dsgouda]

Couple of minor changes apart looks good

[dsgouda]

1. Since there are breaking changes, the minor version must be updated, i.e., 19.1.0-preview
2. PackageReleaseNotes must be updated

[dsgouda]

@sayghosh looks like the signing build was successful

[sayghosh]

@dsgouda Yes it succeeded in second attempt. First time it failed due to some intermittent issue. And addressed the changes requested.

[dsgouda]

LGTM subject to CIs passing

[dsgouda]

@sayghosh We cannot accept this PR. The SDK MUST be generated from master branch of REST specs repo.
Please coordinate with @MikhailTryakhov to create a PR for the May branch and integrate your changes there. `

[MikhailTryakhov]

Hi @sayghosh
the major version would be ready for review tomorrow including all your updates. Can you please wait for it?

[sayghosh]

@MikhailTryakhov Sure :)

[sayghosh]

@dsgouda Please add this requirement as part of the "SDK Generation Guidelines" above so that no duplicate effort goes in raising a wrong PR from any other branch :)

[dsgouda]

Thanks @sayghosh we will update the documentation