[AzureMonitorExporter][AzureMonitorDistro] Update OpenTelemetry packages to 1.8.0#43197
Merged
rajkumar-rangaraj merged 6 commits intoAzure:mainfrom Apr 6, 2024
Merged
Conversation
rajkumar-rangaraj
requested review from
ArthurMa1978,
JoshLove-msft,
KrzysztofCwalina,
TimothyMothra,
annelo-msft,
christothes,
cijothomas,
jsquire,
m-nash,
pallavit,
reyang,
tg-msft,
vishweshbankwar and
xiang17
as code owners
github-actions
bot
added
Monitor - Distro
sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/src/OpenTelemetryBuilderExtensions.cs
Show resolved
Hide resolved
jsquire
reviewed
Apr 4, 2024
Member
jsquire
left a comment
jsquire
left a comment
There was a problem hiding this comment.
Dependency changes in Packages.Data.props are scoped to the Monitor packages and tests only. No objections to the bump.
CodeBlanch
reviewed
Apr 4, 2024
sdk/monitor/Azure.Monitor.OpenTelemetry.LiveMetrics/src/LiveMetricsExtensions.cs
Show resolved
Hide resolved
CodeBlanch
reviewed
Apr 4, 2024
sdk/monitor/Azure.Monitor.OpenTelemetry.LiveMetrics/src/LiveMetricsExtensions.cs
Show resolved
Hide resolved
sdk/monitor/Azure.Monitor.OpenTelemetry.AspNetCore/CHANGELOG.md
Outdated
Show resolved
Hide resolved
TimothyMothra
approved these changes
Apr 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
OpenTelemetryBuilderas obsolete. We are following the same approach as hosting, by suppressing the obsolete message in theUseAzureMonitorAPI. Ref: https://github.com/open-telemetry/opentelemetry-dotnet/blob/b0c95307dd4bb0cab17f07c177773592816ddc09/src/OpenTelemetry.Extensions.Hosting/OpenTelemetryServicesExtensions.cs#L39AddVendorInstrumentationIfPackageNotReferencedwas removed since it only looks for one assembly.Managerinstance to the singleton service collection. This can be retrieved later using Logging Extensions.