-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Update Azure Notification Hubs SDK for 100% swagger coverage #4313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dsgouda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please generate the code using generate.ps1 similar to one here and commit all artifacts generated
- Run
msbuild build.proj /t:Build /p:Scope=SDKs\NotificationHubsand commit all files generated/modified - There are breaking changes introduced here, if a package has already been published, please bump the package id
dsgouda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run msbguild build.proj /t:build /p:Scope=SDKs\NotificationHubs and commit changes to the .props file
dsgouda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologize for the turnaround, there are breaking changes being introduced into the sdk here. Please update the package version in csproj and AssemblyInfo files and this should be good to go.
dsgouda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM subject to CIs passing
@aimankhan thanks for addressing feedback
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
Updating swagger for Notification Hubs to add examples azure-rest-api-specs#3034
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.