Skip to content

Conversation

@aimankhan
Copy link
Contributor

@aimankhan aimankhan commented May 11, 2018

Description


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@aimankhan
Copy link
Contributor Author

@blocphan

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please generate the code using generate.ps1 similar to one here and commit all artifacts generated
  • Run msbuild build.proj /t:Build /p:Scope=SDKs\NotificationHubs and commit all files generated/modified
  • There are breaking changes introduced here, if a package has already been published, please bump the package id

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run msbguild build.proj /t:build /p:Scope=SDKs\NotificationHubs and commit changes to the .props file

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologize for the turnaround, there are breaking changes being introduced into the sdk here. Please update the package version in csproj and AssemblyInfo files and this should be good to go.

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM subject to CIs passing
@aimankhan thanks for addressing feedback

@dsgouda dsgouda merged commit a1ece37 into Azure:psSdkJson6 May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants