[SDKs/LBS] Deprecate LocationBasedServices mgmt .NET SDK#4307
Merged
dsgouda merged 2 commits intoAzure:psSdkJson6from May 11, 2018
Merged
[SDKs/LBS] Deprecate LocationBasedServices mgmt .NET SDK#4307dsgouda merged 2 commits intoAzure:psSdkJson6from
dsgouda merged 2 commits intoAzure:psSdkJson6from
Conversation
dsgouda
suggested changes
May 11, 2018
Contributor
dsgouda
left a comment
dsgouda
left a comment
There was a problem hiding this comment.
Left a few comments.
Do confirm that this does not include any changes to the SDK itself but need changes to the recorded tests and a version update
|
|
||
| <PropertyGroup> | ||
| <PackageId>Microsoft.Azure.Management.LocationBasedServices</PackageId> | ||
| <PackageReleaseNotes>This package is deprecated. Please use https://www.nuget.org/packages/Microsoft.Azure.Management.Maps/ </PackageReleaseNotes> |
Contributor
There was a problem hiding this comment.
Let's make this a little more detailed
You can refer to an example here
| <PackageId>Microsoft.Azure.Management.LocationBasedServices</PackageId> | ||
| <PackageReleaseNotes>This package is deprecated. Please use https://www.nuget.org/packages/Microsoft.Azure.Management.Maps/ </PackageReleaseNotes> | ||
| <Description>Microsoft Azure Management Location Based Services Library</Description> | ||
| <VersionPrefix>1.0.0</VersionPrefix> |
Contributor
There was a problem hiding this comment.
Use Version instead of VersionPrefix
|
|
||
| [assembly: AssemblyVersion("1.0.0.0")] | ||
| [assembly: AssemblyFileVersion("1.0.0.0")] | ||
| [assembly: AssemblyVersion("1.1.0.0")] |
Contributor
There was a problem hiding this comment.
Must match the AssemblyVersion in csproj
| // You can specify all the values or you can default the Build and Revision Numbers | ||
| // by using the '*' as shown below: | ||
| // [assembly: AssemblyVersion("1.0.*")] | ||
| [assembly: AssemblyVersion("1.0.0.0")] |
Contributor
|
Approved, will merge on CIs passing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.LocationBasedServices REST API specs no longer exists.
Refer to Maps PR: Azure/azure-rest-api-specs#3007